Refund API [#2602652]

It would be nice to be able to do refunds (credit requests): https://www.datatrans.ch/showcase/settlement/xml-credit-request

For the time being only as an API so that we could call it from custom code.

Are the maintainers interested in this or should I put this in a custom module instead?

Comment	File	Size	Author
#7	interdiff-5-7.txt	629 bytes	czigor
#7	commerce_datatrans-2602652-7-refund.patch	2.9 KB	czigor
#7
#5	commerce_datatrans-2602652-5-refund.patch	2.92 KB	czigor
#5
#2	commerce_datatrans-2602652-2-refund.patch	3.8 KB	czigor
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

27 October 2015 at 15:54

czigor created an issue. See original summary.

Comment #2

czigor CreditAttribution: czigor at Liip for FREITAG lab. AG commented 28 October 2015 at 13:10

Status:

Active

» Needs review

File	Size
commerce_datatrans-2602652-2-refund.patch	3.8 KB

The API function to call is commerce_datatrans_refund_request($transaction, $amount). For usage see the DOxygen.

Comment #3

mikl CreditAttribution: mikl at Liip commented 6 November 2015 at 10:38

Status:

Needs review

» Reviewed & tested by the community

Comment #4

Berdir

German

Switzerland

CreditAttribution: Berdir at MD Systems GmbH commented 6 November 2015 at 11:23

Status:

Reviewed & tested by the community

» Needs review

index 0000000..9a66f16
--- /dev/null

--- /dev/null
+++ b/commerce-datatrans-refund.tpl.php

Hm, using a template for this is a bit strange.

Can we use something like the xml writer API instead?

It's pretty easy to use and shouldn't be much more complicated than preparing and passing the values to the template.

See http://api.worldempire.ch/api/tmgmt/translators%21file%21tmgmt_file.form... for an example implementation, you just write out tags and attributes seqentually.

Comment #5

czigor CreditAttribution: czigor at Liip for FREITAG lab. AG commented 6 November 2015 at 13:05

File	Size
commerce_datatrans-2602652-5-refund.patch	2.92 KB

1 file was hidden/shown/deleted

File	Size
commerce_datatrans-2602652-2-refund.patch	3.8 KB

The attached patch uses XMLWriter instead of the template.

Comment #6

Berdir

German

Switzerland

CreditAttribution: Berdir at MD Systems GmbH commented 6 November 2015 at 14:06

Status:

Needs review

» Needs work

Nice, looks a lot better I think. The indendation will make coding sniffers unhappy but I agree that it makes it easier to follow for humans.

+++ b/commerce_datatrans.module
@@ -603,3 +603,68 @@ function _commerce_datatrans_settings_ok($settings) {
+  if (empty($amount) || ($amount > $transaction->amount) ) {
+    $amount = $transaction->amount;
+  }
...
+          $writer->writeElement('amount', $transaction->amount);

Shouldn't this be using $amount then, otherwise it's always the full amount?