The description on the getReferenceIds function in the ProductCategoryTrait says the following:
There is no filtering by target type to avoid needlessly loading all field definitions.

Since we’re only keeping track of taxonomy term reference id’s (see the configuration form), I think it’s necessary to add a target type condition in the getReferenceIds function.

I have a case where products have both a term reference and a node reference field. If for example, a product has a reference to a node with the same id of a term used in a promotion, the promotion will apply even if the product is not referencing the given term.

CommentFileSizeAuthor
#3 3079272-2.patch822 byteskennethos
#2 3079272-1.patch0 byteskennethos

Comments

kennethos created an issue. See original summary.

kennethos’s picture

StatusFileSize
new0 bytes
kennethos’s picture

Status: Active » Needs review
StatusFileSize
new822 bytes

Status: Needs review » Needs work

The last submitted patch, 3: 3079272-2.patch, failed testing. View results

rhovland’s picture

Status: Needs work » Closed (duplicate)