If an order entity contains payment_gateway, and we have some shipping method with "Limit by payment gateway" restriction, the method \Drupal\commerce_payment\Plugin\Commerce\Condition\OrderPaymentGateway::evaluate is trying to get its ID and fails with
Error: InvalidArgumentException: Unable to get a value with a non-numeric delta in a list.
We need to get payment gateway ID in correct way
$payment_gateway_id = $order->get('payment_gateway')->target_id;
instead of
$payment_gateway_id = $order->get('payment_gateway')->get('target_id');
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | commerce_get-payment-gw-id_2969613_7.patch | 3.99 KB | martin_klima |
Comments
Comment #2
martin_klimaPatch attached
Comment #4
bojanz commentedWe actually need $order->get('payment_gateway')->first()->get('target_id');
And we need to update the unit test that is failing.
Comment #5
martin_klimaI updated the failing test. I'm not experienced in such kind of tests, and I didn't know how to test first(), then get(), so I used getValue() and tested it locally.
If you think, the $order->get('payment_gateway')->first()->get('target_id') is better approach than getValue(), let me know and I will rewrite it.
Comment #7
martin_klimaComment #8
bojanz commentedRetitling.
Comment #10
bojanz commentedTweaked and committed, thanks!