Closed (won't fix)
Project:
Commerce Core
Version:
7.x-1.x-dev
Component:
Payment
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
25 Jul 2012 at 13:27 UTC
Updated:
25 Feb 2014 at 01:11 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
mr.york commentedHere is a patch.
Comment #2
rszrama commentedFirst, thanks for sharing your patches. It's always appreciated, even if I don't put them in. For this one, I don't think we should include it for two reasons:
That said, I see no problem using it on your own site as it's obviously made your work a little easier. Keep 'em coming! : )
Comment #3
nagy.balint commented2. Unfortunately this does not always work. As having transactions in a payment method is not mandatory.
For example on our site the postfinance payment method never creates a transaction therefore the mentioned relationship ("Commerce Order: Payment Transaction" on our site) and field will always return "unknown" even tho the payment method was Postfinance.
On the other hand the above patch works perfectly (and requires 1 less relationship).
Comment #4
rszrama commentedOk, I still don't think I'll be putting it in as is, though, primarily for reason #1. I'm just not entirely comfortable with that temporal data value making its way into a field handler. That said, why does your payment method not create a transaction? It should at least create a pending transaction to represent that payment is expected, and once payment is received you could have an operation link on that transaction that led to a form to mark it as received. Is that the basic model, or am I misunderstanding what you mean by "postfinance?"
Comment #5
ferelx commentedApplying this patch I lost a payment method. How I can recover it?