It would be very useful if the status of the comment time could be toggled between 'Excluded from node total time' and 'Included in node total time'. As the status names suggest: an excluded comment time would not appear in the total node time.

Use case:
We use Comment timer to account for the time spent on our work. If the worker does something he does not want to get paid for but still wants to keep a record of this time he or she could set the status to 'excluded'.

Patch is coming.

CommentFileSizeAuthor
#6 interdiff-5-6.txt3.01 KBczigor
#6 comment_timer-2182527-6_status.patch12.7 KBczigor
#5 interdiff_4-5.txt1.72 KBczigor
#5 comment_timer-2182527-5_status.patch11.88 KBczigor
#4 interdiff_3-4.txt4.08 KBczigor
#4 comment_timer-2182527-4_status.patch11.88 KBczigor
#3 interdiff-1-3.txt792 bytesczigor
#3 comment_timer-2182527-3_status.patch7.93 KBczigor
#1 comment_timer-2182527-1_status.patch7.08 KBczigor

Comments

czigor’s picture

czigor commented
Status: Active » Needs review
StatusFileSize
new comment_timer-2182527-1_status.patch7.08 KB

The patch adds a new 'status' column to the {comment_timer_comment} table and modifies the comment_timer form by adding a 'status' select box.

czigor’s picture

czigor commented

If you commit this please don't forget to add
--author="czigor <czigor@826222.no-reply.drupal.org>"
to the git commit command.

czigor’s picture

czigor commented
StatusFileSize
new comment_timer-2182527-3_status.patch7.93 KB
new interdiff-1-3.txt792 bytes

Views integration of the comment timer status column was left out.

czigor’s picture

czigor commented
StatusFileSize
new comment_timer-2182527-4_status.patch11.88 KB
new interdiff_3-4.txt4.08 KB

Patch now includes an ajax link that can be added to the comment display as an extra field to toggle the status of the comment time.

czigor’s picture

czigor commented
StatusFileSize
new comment_timer-2182527-5_status.patch11.88 KB
new interdiff_4-5.txt1.72 KB

Some leftover project-specific strings replaced.

czigor’s picture

czigor commented
StatusFileSize
new comment_timer-2182527-6_status.patch12.7 KB
new interdiff-5-6.txt3.01 KB

The new patch has the following changes:

  1. Changes and documents hook_comment_timer_commands_alter().
  2. Using #attached instead of drupal_add_js().
  3. nojs-case goes to node/[nid]#comment-[cid]
  4. A coding standards fix
boobaa’s picture

boobaa
he/him
commented
Status: Needs review » Fixed

Thanks for disturbing me on IRC and Skype about this, finally I committed it. Additionally, you've earned maintainer status on this module as well. ;)

The only nitpick is that the new {comment_timer_comment}.status field lacked any indices. This has been fixed in 0b6035a.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.