Image module - image derivative setting, gallery and image attach support

i have had it working on a development site with no issues. ColorBox uses the correct derivative setting when linking the image-attach-body. I believe thickbox linked the gallery thumbnails too, so that's a possible addition to the javascript.

here's a re-roll with added support for image galleries - ul.images a, added to js/colorbox_image_module.js

I've tested and everything works, thanks!

I'm still tossing around the lines below from my original js code.

    // Determine if we need to link
    if (derivative == '_original' || derivative == settings.image_derivative) {
      return true;
    }

This makes sense since when dealing with a gallery or image attach because all the images are the same derivative. But if the images on the page are mixed derivatives - example: thumbnails, original, preview -- then the original and preview's won't get colorboxed and won't show up in the colorbox gallery slides. Removing these lines can eliminate any of this confusion.

Changes to patch:

1. js/colorbox_image_module.js - removed the following:
   

       // Determine if we need to link
       if (derivative == '_original' || derivative == settings.image_derivative) {
         return true;
       }
   

2. colorbox.module - added an access check for 'view original images'. If image derivative is '_original' and user does not have 'view original images' access then js is not added. This eliminates exposing the original image.

I believe its OK to commit in this state. This is obviously a weak link with the image module which results in these crazy auto js files...

Some things to note about colorbox_image_module.js :

• if the found derivative is '_original', it will result in no replacement since it attempts to replace '._original' with the settings.image_derivative. To accomplish this, you would have to replace the file extension (.jpg) with settings.image_derivative + '.' + extension... I don't believe this extra work is needed since the original image is most likely the largest.
• '_original' is used in the js code... if ambitious, could push IMAGE_ORIGINAL into a settings.colorbox.IMAGE_ORIGINAL
• this will still run into the issue #125610: Incorrect behaviour with image.module, but having this setting is more flexible if a solution is found for the missing files. If users have problems, they can just change the setting to original and accomplish the same result that is described in #125610

not sure on the etiquette but you could override the image modules theme function all together.... for maintaining you would have to keep up with releases of image module.
I have tested with the code below and it will link the colorbox anywhere image calls theme('image_display'), ie this even works for custom views or anywhere for that matter.

This would go into the colorbox.module:

/**
 * Theme an img tag for displaying the image.
 */
function phptemplate_image_display($node, $label, $url, $attributes) {
  $title = isset($attributes['title']) ? $attributes['title'] : $node->title;
  $alt = isset($attributes['alt']) ? $attributes['alt'] : $node->title;
  $image = theme('image', $url, $alt, $title, $attributes, FALSE);

  if (variable_get('colorbox_auto_image_nodes', 0)) {
    $image_derivative = variable_get('colorbox_image_derivative', IMAGE_PREVIEW);
    if ($node->images[$image_derivative]) {
      return l($image, $node->images[$image_derivative], array('html' => TRUE, 'attributes' => array('title' => $title, 'class' => 'colorbox', 'rel' => 'image-gallery')));
    }
  }

  return $image;
}

theme override in #11 causes problems with img_assist and would need to have some conditions before applying the link, ie check if arg(0) == 'img_assist'... this could turn out more troublesome than the js method...
thoughts?

I'm all for a cleaner way of doing this, but from past issues it looks like thickbox was forced to do it this with js.