"Collapsible, collapsed by default" does not work

Subscribing...

I think it cannot be a feature request...

I had a js developer tweak one of the files in the module, and it now works very well for me. I'm attaching it to this post, perhaps it can be of use to someone else (my current version is 6.x-1.x-dev).

Thanks for posting your suggested change. Could you please explain what the patch does, and what changes after it is applied?

Attached is a screenshot of the original and modified files. I'm not a js programmer, so I'm not sure how, but the new version fixes this ticket and does a better job of remembering the block's collapsed/expanded state, and will also allow for cookies to remember the users collapsed/expanded setttings. Works well and has greatly improved the look of my site. Contact me if you want to get in touch with the developer who did the work.

Thanks for following up.

However, please consider the following.

Like dozens of other modules that I wrote and maintain as a volunteer, collapsiblock is something I put together years ago as a volunteer, have never been paid to do any work on, and have never used on a site.

This issue is only one of many that I deal with every week.

You have hired a developer to fix an issue. What makes more sense: that I should need to track down that developer and try to get an explanation of what he did and why?

Or that you should think of getting the fix into the software as part of - in fact, the main purpose of - hiring a developer? And, yes, part of the cost. If for no reason, so that, when you upgrade to a new release, you don't need to reapply a patch every time.

If the developer's work ends the moment you have a hack that "works" on your site, you're missing a lot of the point and the benefit of open source.

If you want a patch that you submit to go in, please take the time to do the small amount of additional work that is required to make that possible. Thank you.

Again, thanks for the contribution. I'll be happy to review the patch if someone can provide some explanation.

I've added a section to the handbook page on hiring a Drupal developer with suggestions on how and why to contribute back:
http://drupal.org/node/51169#contribute-back

Hi nedjo, I've made some changes I wanted and included a patch. The first change adds a fourth option to the existing settings, which sets blocks to be always collapsed rather than remembering the state with the cookie, as per the feature request.

I've also added another couple of settings which deal with the animation of the block. You can choose whether you want blocks to slide open as before or use a fade and slide effect. You can also set the speed of the effect. Both these extra settings are globally set in the admin settings page.

I haven't done any validation on the speed entry field and I'm guessing that the script could get broken easily by entering something other than a number here.

Let me know if you need any more info on the patch.

Thanks for the helpful link nedjo.

Thanks Tanc and Vote_Sizing_Steve.

I've committed Tanc's changes in full--nice work!--worked in something drawing on the fix from Vote_Sizing_Steve, and refactored the cookie handling to address #345684: too many collapsable blocks causes the user to be logged out.

Leaving the status at needs review because I'd appreciate some confirmation that the issues are now addressed. With that in place I'll issue a new stable release.

Thanks all.

Thanks for committing my patch nedjo. Unfortunately something seems to be broken with the new CVS version. It looks like its a problem with the cookie in passing it the JSON string. I'm getting a 'Data is NULL' in my js console which hoses all the other javascript in the site. I've set a breakpoint and I'm pretty sure that its the 4th line of the collapsiblock js that's causing it although that's as far as my debugging knowledge goes. I've tested this on a live site and to be sure on a fresh Garland based install.

Any ideas?

@Tanc: Thanks for testing. I've applied a follow up patch to ensure we have cookie data before trying to parse it with Drupal.parseJson(). I think that should solve the issue, but more testing of that and the rest of the patch would be great.

haha, nedjo, your timing is impeccable! I had just fixed the issue (with less elegant code) and was about to roll a patch. Testing yours and everything is fine. I've deleted the cookie and no longer have the null data issue. All good from here!

Seems to be working.

strangely, on my site every setting results in all blocks being open at outset, and state being remembered.

is there any info that would be helpful to reproducing?

I've just upgraded to d6.8 and simultaneously upgraded to the dev version of collapsiblock available yesterday. Ran update.php a few times. Deleted all cookies a few times. Tested in IE7, Chrome, Firefox (mac & pc) and Safari (mac). Using Zen subtheme, fwiw.

Collapsiblock is set to 'collapsed all the time,' and I've tried several of the settings, but always get all open at outset, and state remembered. Before the upgrade, all blocks were closed at outset and state remembered.

hope this bug report is of use....

Thanks for the report.

I would so appreciate someone taking the time to look at the code and address this issue.

I'm seeing the same issue as #16, using the current dev release.

@grendzy - what theme are you using?

are others seeing things work with a given theme?

I'm using a custom zen sub-theme.

I switched to Garland, just for testing -- and I'm still seeing the same thing. "Expandable, collapsed by default" has no effect. I made sure to clear all my cookies too.

Here is a patch from cyberpunk in #375215: "collapsible & collapsed" setting doesn't work

This patch works for me!

similar issue: #232332: QT Always not collapsed

I can confirm that the patch @ #21 works for me too.

I confirm patch from #21 works for us too. Tested on Firefox 3.0.13 and IE 7.0.5730.13.

Thanks.

I'll also confirm that the patch posted in #21 works perfectly.
Blocks that would previously start opened, even though they were specified to start closed, now start closed but still remember their last opened/closed state.
Tested in Google Chrome and Firefox.

#21 patch works for me.

Nedjo, please commit ASAP! This is a basic, silly bug.

Can we please have a stable version released - if the problems have been "patched up" (I hope this is the acceptable way of making such a request)

Thanks, committed.

I'm still seeing this problem after downloading the latest version of the module and on both firefox and chrome. I also tried applying the patch from #21 but no dice.

And I too am seeing the same thing. I applied the patch, but my blocks do not collapse. Does the module work with the Earthen theme?

@Aaron Hawkins with theme do you use?
@KAP10 no Earthen will be certainly never supported because this theme change all the default class and id (and not only the title one). Please ask the Earthen they use "standard" CSS class.

@gagarine:
How can i manage, that Collapsibleblock will remember exactily the block, what i make collapsed. Becaouse if i have all open and i decide to close one, when i click f5, all block are collapsed. Do you please know, what do do with it ? Please help

http://ekoporno.cz/ here is it ..

@kryber On your website it works for me. But perhaps I don't get your request. Please open a new issue.

to everyone... please keep this issue close for ever

Some blocks do not collapse by default, they only collapsed if set to "collapsed all the time

This behavior affects at least the OG "My groups" block

.

Read #37