Hello all, it’s time for the fortnightly coding standards meeting.
This meeting:
➤ Is for anyone interested in the Drupal coding standards.
➤ Is held on the #coding standards channel in Drupal Slack (see www.drupal.org/slack for information).
➤ Usually happens fortnightly. Alternating between Tuesday 2100 UTC and Wednesday 0900 UTC.
➤ The meeting open for 24 hours to allow for all time zones.
➤ Discussion is done in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously.
➤ Has a public agenda anyone by adding a comment to the meeting issue.
➤ A transcript will be made using drupal-meeting-parser and posted to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.
➤ The transcript will include comments made during the 24 hours of the meeting. However, comments made after the 24 hours may not be in transcript.
Current ping list: @catch, @longwave, @quietone
@dww, @borisson_ @longwave @Björn Brala, @Aaron McHale, @Alex Skrypnyk, @Kingdutch, @Tyler Staples (nexusnovaz)
1️⃣ What topics do you want to discuss? Post in this thread and we’ll open threads for them as appropriate.
| smustgrave | Not a topic but could use help with this as there are lot of open threads if anyone is free (quietone you worked on it)#3517369: Fix Drupal.Commenting.FunctionComment.Missing in test module fixtures |
2️⃣ Action items
2️⃣.1️⃣ Approve minutes for previous meeting(s)
| quietone | Previous minutes are RTBC! |
| quietone | https://www.drupal.org/project/coding_standards/issues/3576923 |
2️⃣.2️⃣ Issues to go to core committer meeting
2️⃣.3️⃣ TBD
3️⃣ Committee membership
| quietone | This committee is working to follow the practice used for Drupal core subsystem and topic maintainer of checking in annually to see if they wish to continue in the role. |
| quietone | That has been done and both @Aaron McHale and @urvashi_vora have stepped down. |
| quietone | Thank you to @Aaron McHale and @urvashi_vora for giving their time and expertise to the Drupal Coding Standards committee! |
| quietone | Further the current members have noticed that @borisson_ has been steadily contributing and keeping things moving and we posted an issue to add them as a member of the committee. |
| borisson_ | Is there anything I need to do on this issue to accept this position formally? |
| quietone | Good question! For now I think not. There are docs about the committee and the task but I don't think we ever finalized them. Plus I never figured out where to post them. |
| quietone | I guess an acknowledgement that you have been involved for a long time and are aware of the responsibility? |
| borisson_ | Ok, I'll post that on the issue |
4️⃣ RTBC issues
4️⃣.1️⃣ Classes and interfaces without a backslash \ inside their fully-qualified name must be fully qualified
| quietone | This needs an MR to proceed. |
| quietone | Who would like to do that? |
4️⃣.2️⃣ Stop using FQCN in PHPDoc annotations
| quietone | This one needs a change record |
4️⃣.3️⃣ Add conditions to deciding if a blog post is needed (edited)
| quietone | This just needs someone to that the changes are correct and no typos introduced. |
5️⃣ From last meeting
5️⃣.1️⃣ Remove the requirement for doxygen for test methods
| quietone | In the issue @borisson_ asked if I agree with the suggestion from longwave. I do agree. |
| quietone | I've been out with the flu and didn't comment. |
| quietone | I applied the suggestion. |
| quietone | I guess this can move on now. |
| quietone | I mean step 7 final review. |
| quietone | @smustgrave mentioned the core issue that is adding docs for test files in core/modules. |
| quietone | As I recall, much of the documentation added in that issue would not be necessary if this was adopted. |
| quietone | Oh this issue is[#3517369] |
| quietone | I postponed that core issue while we finalize this issue. |
| smustgrave | Thanks for taking a look. I didn’t want to let it sit there forever just endless rebasing |
5️⃣.2️⃣ Replace @inheritdoc annotations with #[\Override]
| quietone | Looks like this needs an MR |
| borisson_ | I've started working on a change for the api.d.o to parse these as well. I hope to put up an issue and mr sometime this weekend. |
Comments
Comment #2
quietone commentedComment #3
quietone commentedComment #4
quietone commentedComment #5
borisson_Looks like nothing is missing from the slack conversation.