Problem/Motivation
Enums and Traits should use UpperCamel naming, this is currently not checked in Coder
The checking is done by the Drupal.NamingConventions.ValidClassName sniff.
Steps to reproduce
Write bad enum or trait names.
Proposed resolution
- Expand checking of ValidClassNameSniff to traits and enums.
Test examples:
class CorrectClassName {}
class CorrectClassWithAReallyLongName {}
class INCORRECT_CLASS_NAME {}
class INCORRECTCLASSNAME {}
class incorrectLowercaseClassName {}
interface CorrectInterfaceName {}
interface CorrectInterfaceWithAReallyLongName {}
interface INCORRECT_INTERFACE_NAME {}
interface INCORRECTINTERFACENAME {}
interface incorrectLowercaseInterfaceName {}
trait CorrectTraitName {}
trait CorrectTraitWithAReallyLongName {}
trait INCORRECT_TRAIT_NAME {}
trait INCORRECTTRAITNAME {}
trait incorrectLowercaseTraitName {}
enum CorrectEnumName {}
enum CorrectEnumWithAReallyLongName {}
enum INCORRECT_ENUM_NAME {}
enum INCORRECTENUMNAME {}
enum incorrectLowercaseEnumName {}
Remaining tasks
pull request
API changes
None
Comments
Comment #3
klausiMerged https://github.com/pfrenssen/coder/pull/256
Comment #5
klausiCoder 8.3.28 was released with this fix.