Forbid upper case acronyms in class, enum, interface, trait names

Problem/Motivation

Since 2013 acronyms are not allowed in all upper case form in class names https://www.drupal.org/docs/develop/standards/php/php-coding-standards#s... . This is currently not checked in Coder

The checking is done by the Drupal.NamingConventions.ValidClassName sniff.

If we make this checking more strict then we will get many naming fails in Drupal 11 core, see https://github.com/pfrenssen/coder/actions/runs/12619249748/job/35163551208 . For example:

• ConfigCRUDTest
• FTPExtension
• PDOConnection
• NodeTranslationUITest

Class names are case insensitive in PHP: https://www.php.net/manual/en/language.oop5.basic.php#122293
So we can rename the casing of classes without breaking existing code.

We cannot write a PHPCS fixer for this as it cannot update all references to a class. But maybe there are other tools like Rector that can do the renaming.

Another workaround is possible by telling PHPCS to ignore the class declaration line:

/**
 * Doc block is here and an ignore directive is ok.
 */
// phpcs:ignore Drupal.NamingConventions.ValidClassName
enum PUROSELY_WRONG_BUT_OK: int {
  case One = 1;
  case Two = 2;
}

Steps to reproduce

Write bad class names.

Proposed resolution

• I thought about changing the error codes to give developers more fine grained control for silencing. Changing error codes would be a small API break and I think there is not much to gain. Since classes are in separate files the error can be silenced on the file path level in phpcs.xml.dist. The error can also be silenced in a comment with phpcs:ignore before the class.

Test examples:

class CorrectClassName {}
class CorrectClassWithAReallyLongName {}
class IncorrectJSONClassName {}
class INCORRECT_CLASS_NAME {}
class INCORRECTCLASSNAME {}
class incorrectLowercaseClassName {}

interface CorrectInterfaceName {}
interface CorrectInterfaceWithAReallyLongName {}
interface IncorrectJSONInterfaceName {}
interface INCORRECT_INTERFACE_NAME {}
interface INCORRECTINTERFACENAME {}
interface incorrectLowercaseInterfaceName {}

trait CorrectTraitName {}
trait CorrectTraitWithAReallyLongName {}
trait IncorrectJSONTraitName {}
trait INCORRECT_TRAIT_NAME {}
trait INCORRECTTRAITNAME {}
trait incorrectLowercaseTraitName {}

enum CorrectEnumName {}
enum CorrectEnumWithAReallyLongName {}
enum IncorrectJSONEnumName {}
enum INCORRECT_ENUM_NAME {}
enum INCORRECTENUMNAME {}
enum incorrectLowercaseEnumName {}

Remaining tasks

Discuss if this is what we want, then finish https://github.com/pfrenssen/coder/pull/255

API changes

None