COD Base is showing an overridden state as soon as it is enabled, specifically in the Field Permissions section, but it is not identifying which permission is overridden.

Comments

twardnw’s picture

Status: Active » Needs review
StatusFileSize
new8.77 KB

So I recreated the feature with no changes made. Looking at the patch file, it looks like the fields now have a 'locked' setting, which is '0' in every case. Features also changed the way it comments, comments now end with a period:

-  // Exported permission: administer users
+  // Exported permission: administer users.
greggles’s picture

This looks good on a visual review and applies cleanly to 7.x-1.x-dev. I didn't actually test it.

sheldonkreger’s picture

Status: Needs review » Reviewed & tested by the community

Patch in 1 also applied cleanly for me, and resolved the "override" issue in COD Base.

saltednut’s picture

Patch applies cleanly. Enabling cod_base shows its no longer overridden. Looks RTBC!

sheldonkreger’s picture

Issue tags: +da_drupalcon

Please note that patch #3 in http://drupal.org/node/1672922 relies on #1 in this thread.

cafuego’s picture

Yup, +1 for RTBC here as well.

ezra-g’s picture

Status: Reviewed & tested by the community » Postponed

Looks like this would be resolved as part of the re-exporting that would happen to fix #1477754: Rename "site administrator" role to "administrator", which means it's either a duplicate or postponed.

japerry’s picture

Status: Postponed » Active

Looking at this issue brings some complicated issues -- I think most sites are going to have varying user permissions.

I think an alternative is having a set of sane permissions set by the cod distribution installer, and not by features. Permissions start to get into the content realm since conferences will almost always vary how they want to do this.

Also, cod_events and other features implementing permissions will show as overridden. Because of this, and the idea to keep features default as much as possible, we shouldn't put permissions in the features.

japerry’s picture

Status: Active » Fixed

Fixed in alpha2 by putting the administrator permissions in the install by default

greggles’s picture

Thanks for the work, Jakob.

It would be nice if you could link from the comment closing an issue to the commit message where the change was made (and ideally post a patch prior to committing it). I understand when sprinting things happen quickly so even just committing and linking (instead of posting the patch) seems reasonable.

Automatically closed -- issue fixed for 2 weeks with no activity.