Problem/Motivation

  • Typehinting will be required before drupal:10.0.0.
CommentFileSizeAuthor
#4 3191586-4.patch9 KByas

Issue fork cloud-3191586

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yas created an issue. See original summary.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Related issues: +#3191576: Add function's return type declaration (AWS Cloud), +#3191580: Add function's return type declaration (Cloud), +#3191581: Add function's return type declaration (K8s), +#3191582: Add function's return type declaration (Docker), +#3191583: Add function's return type declaration (OpenStack), +#3191584: Add function's return type declaration (Terraform), +#3191585: Add function's return type declaration (VMware), +#3191587: Add function's return type declaration (Tools)

yas opened merge request !98

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: Add function's return type declaration (Gapps) » Add function's return type declaration (GApps)
Status: Active » Needs review
StatusFileSize
new 3191586-4.patch9 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Assigned: Unassigned » yas
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Related issues: +#3191610: Add function's return type declaration (Cloud Budget)
xiaohua guan’s picture

xiaohua guan commented
Status: Needs review » Reviewed & tested by the community

@yas

The MR looks good to me.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@xiaohua-guan

Thank you for your review. I'll merge the patch to 8.x-2.x and 3.x and close this issue as Fixed.

  • yas committed 9d40558 on 8.x-2.x 
    Issue #3191586 by yas, Xiaohua Guan: Add function's return type...

  • yas committed 21ef2e8 on 3.x 
    Issue #3191586 by yas, Xiaohua Guan: Add function's return type...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

yas closed merge request !98

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.