Problem/Motivation

  • Typehinting will be required before drupal:10.0.0.
CommentFileSizeAuthor
#38 3191584-38.patch116.94 KByas
#35 3191584-35.patch116.79 KBiuana
#33 3191584-33.patch118.72 KBiuana
#31 3191584-31.patch118.46 KBiuana
#28 3191584-28.patch134.92 KBiuana
#26 3191584-26.patch143.13 KBiuana
#25 3191584-25.patch151.48 KBiuana
#24 3191584-24.patch149.77 KBiuana
#22 3191584-22.patch124.45 KBiuana
#20 3191584-20.patch122.99 KBiuana
#18 3191584-18.patch120.78 KBiuana
#17 3191584-17.patch120.9 KBiuana
#14 3191584-14.patch80.96 KBiuana
#12 3191584-11.patch73.74 KBiuana
#10 3191584-10.patch73.74 KBiuana
#8 3191584-8.patch71.17 KBiuana

Issue fork cloud-3191584

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yas created an issue. See original summary.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Related issues: +#3191576: Add function's return type declaration (AWS Cloud), +#3191580: Add function's return type declaration (Cloud), +#3191581: Add function's return type declaration (K8s), +#3191582: Add function's return type declaration (Docker), +#3191583: Add function's return type declaration (OpenStack), +#3191585: Add function's return type declaration (VMware), +#3191586: Add function's return type declaration (GApps), +#3191587: Add function's return type declaration (Tools)
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Related issues: +#3191610: Add function's return type declaration (Cloud Budget)

iuana made their first commit to this issue’s fork.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Assigned: Unassigned » iuana

iuana opened merge request !142

iuana closed merge request !142

iuana’s picture

iuana commented
StatusFileSize
new 3191584-8.patch71.17 KB

I've added the patch.

iuana reopened merge request !142

iuana’s picture

iuana commented
Status: Active » Needs review
StatusFileSize
new 3191584-10.patch73.74 KB
dii’s picture

dii commented
Status: Needs review » Needs work

@iuana

Thank you for the refactoring. The patch file needs to have CR/LF at the end of the file. Please upload the patch file again. Thanks

iuana’s picture

iuana commented
Status: Needs work » Needs review
StatusFileSize
new 3191584-11.patch73.74 KB

Yes, indeed. Thank you!

Status: Needs review » Needs work

The last submitted patch, 12: 3191584-11.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

iuana’s picture

iuana commented
Status: Needs work » Needs review
StatusFileSize
new 3191584-14.patch80.96 KB
iuana’s picture

iuana commented
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@iuana

Thank you for the update.

  1. Please add use Symfony\Component\HttpFoundation\RedirectResponse; into its interface / class if the method has the RedirectResponse return type hint.
  2. Please fix the following error:
    $ drush cr

Fatal error: Declaration of Drupal\aws_cloud\Form\Ec2\SecurityGroupDeleteMultipleForm::processCloudResource(Drupal\cloud\Entity\CloudContentEntityBase $entity) must be compatible with Drupal\cloud\Form\CloudProcessMultipleForm::processCloudResource(Drupal\cloud\Entity\CloudContentEntityBase $entity): bool in /var/www/html/web/modules/contrib/cloud/modules/cloud_service_providers/aws_cloud/src/Form/Ec2/SecurityGroupDeleteMultipleForm.php on line 15
 [warning] Drush command terminated abnormally.

Thanks

iuana’s picture

iuana commented
Status: Needs work » Needs review
StatusFileSize
new 3191584-17.patch120.9 KB

Hello @yas
I fixed what you've mentioned and also I've added the rest of return type declaration of the Terraform module.
Thank you!

iuana’s picture

iuana commented
StatusFileSize
new 3191584-18.patch120.78 KB

Update: This is the correct patch added.

Status: Needs review » Needs work

The last submitted patch, 18: 3191584-18.patch, failed testing. View results

iuana’s picture

iuana commented
Status: Needs work » Needs review
StatusFileSize
new 3191584-20.patch122.99 KB

Status: Needs review » Needs work

The last submitted patch, 20: 3191584-20.patch, failed testing. View results

iuana’s picture

iuana commented
Status: Needs work » Needs review
StatusFileSize
new 3191584-22.patch124.45 KB

Status: Needs review » Needs work

The last submitted patch, 22: 3191584-22.patch, failed testing. View results

iuana’s picture

iuana commented
Status: Needs work » Needs review
StatusFileSize
new 3191584-24.patch149.77 KB
iuana’s picture

iuana commented
StatusFileSize
new 3191584-25.patch151.48 KB
iuana’s picture

iuana commented
StatusFileSize
new 3191584-26.patch143.13 KB

Status: Needs review » Needs work

The last submitted patch, 26: 3191584-26.patch, failed testing. View results

iuana’s picture

iuana commented
Status: Needs work » Needs review
StatusFileSize
new 3191584-28.patch134.92 KB

Status: Needs review » Needs work

The last submitted patch, 28: 3191584-28.patch, failed testing. View results

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@iuana

Thank you for refactoring. I reviewed the patch. Please see my above comments. Thanks.

iuana’s picture

iuana commented
Status: Needs work » Needs review
StatusFileSize
new 3191584-31.patch118.46 KB

Thank you for reviewing my work. I've resolved the threads.

Status: Needs review » Needs work

The last submitted patch, 31: 3191584-31.patch, failed testing. View results

iuana’s picture

iuana commented
Status: Needs work » Needs review
StatusFileSize
new 3191584-33.patch118.72 KB

Status: Needs review » Needs work

The last submitted patch, 33: 3191584-33.patch, failed testing. View results

iuana’s picture

iuana commented
Status: Needs work » Needs review
StatusFileSize
new 3191584-35.patch116.79 KB
xiaohua guan’s picture

xiaohua guan commented
Status: Needs review » Reviewed & tested by the community

@yas @iuana

My comments were resolved. So I changed the status RTBC.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work

@iuana @xiaohua-guan

I found the other three occurrences to change to the alphabetical order. I switched back the status to Needs work. Please check those.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs work » Reviewed & tested by the community
StatusFileSize
new 3191584-38.patch116.94 KB

@iuana

Thank you for the update. It looks good now. I'll merge the patch to 3.x and close this issue as Fixed.

  • yas committed f587af9 on 3.x 
    Issue #3191584 by iuana, yas, Xiaohua Guan: Add function's return type...

yas closed merge request !142

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.