Problem/Motivation

  • Typehinting will be required before drupal:10.0.0.
CommentFileSizeAuthor
#27 3191580-27.patch124.67 KBxld
#20 3191580-20.patch208.16 KBxld
#19 3191580-19.patch208.82 KBxld
#17 3191580-17.patch208.82 KBxld
#15 3191580-15.patch198.87 KBxld
#12 3191580-12.patch820.9 KBxld
#7 3191580-7.patch130.69 KBxld

Issue fork cloud-3191580

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

yas created an issue. See original summary.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Related issues: +#3191576: Add function's return type declaration (AWS Cloud), +#3191581: Add function's return type declaration (K8s), +#3191582: Add function's return type declaration (Docker), +#3191583: Add function's return type declaration (OpenStack), +#3191584: Add function's return type declaration (Terraform), +#3191585: Add function's return type declaration (VMware), +#3191586: Add function's return type declaration (GApps), +#3191587: Add function's return type declaration (Tools)
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Related issues: +#3191610: Add function's return type declaration (Cloud Budget)

XLD made their first commit to this issue’s fork.

xld’s picture

xld commented
Assigned: Unassigned » xld

XLD opened merge request !236

xld’s picture

xld commented
Status: Active » Needs review
StatusFileSize
new 3191580-7.patch130.69 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@XLD

Thank you for the update. It looks good to me. I'll change the status to RTBC. Please continue to work on the same repository and change the status to Needs review when you finish the next refactoring. Thanks

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Version: 3.x-dev » 4.x-dev
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@XLD

The tests have been passed successfully, so I'll merge the patch to 4.x and close this issue as Fixed.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Needs work

@XLD

The patch is now behind against HEAD on 4.x branch. Could you please rebase and resolve the conflicts? I'll change the status to Needs work. Thanks

xld’s picture

xld commented
StatusFileSize
new 3191580-12.patch820.9 KB
xld’s picture

xld commented
Status: Needs work » Needs review
xld’s picture

xld commented
Status: Needs review » Needs work
xld’s picture

xld commented
Status: Needs work » Needs review
StatusFileSize
new 3191580-15.patch198.87 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@XLD

Thank you for the update. It looks good to me now.

xld’s picture

xld commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3191580-17.patch208.82 KB

Status: Needs review » Needs work

The last submitted patch, 17: 3191580-17.patch, failed testing. View results

xld’s picture

xld commented
Status: Needs work » Needs review
StatusFileSize
new 3191580-19.patch208.82 KB
xld’s picture

xld commented
StatusFileSize
new 3191580-20.patch208.16 KB
baldwinlouie’s picture

baldwinlouie commented

@yas and @XLD, Thank you for the patch. It looks good to me.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@baldwinlouie

Thank you for your review. I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed adfacdd on 4.x authored by XLD 
    Issue #3191580 by XLD, yas, baldwinlouie: Add function's return type...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

yas closed merge request !236

XLD opened merge request !300

xld’s picture

xld commented
Status: Fixed » Needs review
StatusFileSize
new 3191580-27.patch124.67 KB
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@XLD

Thank you for the refactoring. It looks perfect, so I'll merge the patch to 4.x and close this issue as Fixed.

  • yas committed ef3c33c on 4.x authored by XLD 
    Issue #3191580 by XLD, yas: Add function's return type declaration (...

yas closed merge request !300

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.