Edit user data of a instance

@xiaohua-guan

Thank you for providing the patch. I tested the patch, and I have the following concerns:

• Case 1:
  1. Clicked Edit User Data menu from the dropdown list on my instance in the instance listing view.
  2. Modified my User Data.
  3. Clicked Reboot button.
  4. It gives the error as the following screenshot:
     → We need to stop the instance before we modify the User Data.
• Case 2:
  1. Launched my instance w/ my User Data.
  2. Tried to edit the instance.
  3. The User Data textarea was disabled and empty as the following screenshot:
• Case 3:
  1. Tried to edit my User Data a couple times
  2. After that, the User Data shows in Instance detailed view as the following screenshot (looks Base64 encoded?):

My suggestions and requests:

1. If the instance is stopped, User Data textarea is editable w/ the current User Data content in the Instance Edit View.
2. If the instance is running, User Data textarea is disable w/ the current User Data content in the Instance Edit View.
3. If the instance is stopped, Edit User Data menu from the dropdown list is shown.
4. If the instance is running, here are two suggestions:
   1. Edit User Data menu from the dropdown list is not shown.
   2. _OR_Edit User Data menu from the dropdown list is shown on purpose. When a user click the Edit User Data menu, an alert message should be shown like: To edit your instance's user data you first need to <strong></em><a href="[LINK_TO_STOP_INSTANCE]">stop</a></em></strong> your instance. on the Instance listing view or the Instance Edit View

What do you think?

@xiaohua-guan

Thank you for the updated patch! It looks good to me, but could you please change hook_update_N to aws_cloud_update_8146 since 3056198-6.patch will be merged soon. Also, I would like to add a link to start operation in a notification message:

@xiaohua-guan, Thank you for the patch. I have the following comment.

+++ b/modules/cloud_service_providers/aws_cloud/aws_cloud.install
@@ -740,6 +740,13 @@ function aws_cloud_update_8144() {
+  aws_cloud_update_entity_definitions();

Can you check if this function still works with 8.7.X?

View these links for more information:
https://www.drupal.org/project/drupal/releases/8.7.0 - Under the "Important Update Information" section.
https://www.drupal.org/node/3034742

@xiaohua-guan

Thank you for the updated patch. I created the interdiff.

@baldwinlouie
@masami

What do you think?

@all

Sorry, I replaced the interdiff since my previous one was wrong.

@all, this looks good.

@baldwinlouie

Thank you for your review. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.

@xiaohua-guan

Thank you for the bugfix. I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.