After assuming an IAM role, add the ability to switch to another role.

CommentFileSizeAuthor
#9 3056198-9-interdiff.txt3.46 KByas
#9 3056198-9.patch29 KByas
#6 3056198-6.patch29.25 KByas
#5 3056198-2.patch29.25 KBbaldwinlouie
#4 3056198-1.patch28.35 KBbaldwinlouie
#2 3056198.patch23.35 KBbaldwinlouie

Comments

baldwinlouie created an issue. See original summary.

baldwinlouie’s picture

baldwinlouie commented
Status: Active » Needs review
StatusFileSize
new 3056198.patch23.35 KB

Attaching patch.

Status: Needs review » Needs work

The last submitted patch, 2: 3056198.patch, failed testing. View results

baldwinlouie’s picture

baldwinlouie commented
Status: Needs work » Needs review
StatusFileSize
new 3056198-1.patch28.35 KB

Updating the patch to support assume/switch role when "Use instance credentials" is enabled.

baldwinlouie’s picture

baldwinlouie commented
StatusFileSize
new 3056198-2.patch29.25 KB

Updating patch to fix updating snapshots. Also updated the "Account ID" terminology for field_switch_role field.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3056198-6.patch29.25 KB

@baldwinlouie

Thank you for the update patch. It looks good to me but I changed the patch for hook_update_N since we merged the patch 3056523-5.patch.

@xiaohua-guan
@masami

What do you think?

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Related issues: +#3056523: Display 'public ip' as a link to Elastic IP detailed page in Instance listing view
xiaohua guan’s picture

xiaohua guan commented

@yas

I think the uuid should be remove from the yml file, such as field.field.cloud_config.aws_ec2.field_switch_role.yml, because the uuid is identifier in a specific environment.

+uuid: 13c4e695-e092-4f3d-b990-522300b767fc
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
StatusFileSize
new 3056198-9.patch29 KB
new 3056198-9-interdiff.txt3.46 KB

@xioahua-guan

Nice catch, thank you for your review. I updated the patch. Please confirm.

xiaohua guan’s picture

xiaohua guan commented

@yas

Thanks for your patch. It's ok to me now.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Reviewed & tested by the community

@xiaohua-guan

Thank you for your review. The tests are passed successfully, so I'll merge the patch to 8.x-1.x and 8.x-2.x and close this issue as Fixed.

  • yas committed d685a16 on 8.x-1.x 
    Issue #3056198 by baldwinlouie, yas, Xiaohua Guan: Add ability to switch...

  • yas committed ad137e4 on 8.x-2.x 
    Issue #3056198 by baldwinlouie, yas, Xiaohua Guan: Add ability to switch...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.