Closed (fixed)
Project:
Cloud
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
10 May 2019 at 00:31 UTC
Updated:
24 May 2019 at 18:04 UTC
Jump to comment: Most recent, Most recent file
| Comment | File | Size | Author |
|---|---|---|---|
| #14 | 3053872-14.patch | 3.66 KB | xiaohua guan |
Comments
Comment #2
xiaohua guan commentedComment #3
xiaohua guan commentedIf the user data is something like the below, it will fail to launch.
Comment #4
yas@xiaohua-guan
Could you please check a
/var/log/cloud-init-output.logfile in your launched instance? ... uh, launch itself would fail.. sorry..Comment #5
xiaohua guan commentedComment #6
xiaohua guan commentedComment #7
xiaohua guan commented@yas
Please review the patch file. Thanks.
Comment #8
yas@xiaohua-guan
Thank you for providing the patch. I found that the launch confirmation page has redundant
<br />in each line in User Data field. If possible, can you remove<br />?FYI, the following is the screenshot:
Comment #9
yas@xiaohua-guan
Use this one for the testing:
Comment #10
xiaohua guan commented@yas
It seems there is nothing wrong in my local browser. Could you confirm the image below?
If I removed the
, the content will be displayed in just one line.
Comment #11
xiaohua guan commentedComment #12
yas@xiaohua-guan
What I want to expect is that it displays the user-data as it is including the white spaces to keep the indents. In my
css, I wanted to apply something like this:Since User Data field is special, so if you can put
<pre>...</pre>in that User Data field in the confirmation screen, that would be great. Is that possible?Comment #13
xiaohua guan commentedComment #14
xiaohua guan commentedComment #15
xiaohua guan commented@yas
I added a formatter to deal with it.
Please review the new patch file. Thanks.
Comment #16
yas@xiaohua-guan
Thank you for the updated patch. This is sooo fantastic!
@baldwinlouie
@masami
What do you think?
Comment #17
baldwinlouie commented@all, this one looks good.
Comment #18
yas@baIdwinlouie
Thank you for your review. Then, I'll merge the patch to
8.x-1.xand8.x-2.xand close this issue asFixed.Here is the screenshot for the comment #15
Comment #21
yas