Hi,

After extracting library into module directory and doing everything exactly as specified in readme file got:
Fatal error: Call to undefined function language_initialize() in C:\wamp\www\d6test1\sites\all\modules\click_heatmap\click_heatmap.module on line 149

Drupal 6.3, Click Heatmap 2.5
Windows XP, wamp

CommentFileSizeAuthor
#4 click_heatmap.module.patch2.46 KBunivate
#3 click_heatmap.patch2.04 KBwulff

Comments

playfulwolf’s picture

playfulwolf commented

sorry :) commented out that function.

boombatower’s picture

boombatower commented
Status: Active » Postponed (maintainer needs more info)

So is there still a bug?

wulff’s picture

wulff commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new click_heatmap.patch2.04 KB

This is still a bug. The attached patch fixes the problem (and removes some trailing whitespace).

AFAICT the problem is that in click_heatmap_remove_language_prefix() we're tryingto call the function language_initialize() which may not be available.

Looking through drupal_init_language() in bootstrap.inc, language.inc is only included if the site uses two or more languages.

The fix in this patch simply includes language.inc in click_heatmap_remove_language_prefix().

univate’s picture

univate commented
StatusFileSize
new click_heatmap.module.patch2.46 KB

This is definitely a bug for sites only using one language.

I have done what I think is a cleaner fix to just check the number of languages, no need to do anything in the function click_heatmap_remove_language_prefix() if there is only the one language in use (and I've left the whitespace fixes from the previous patch)

boombatower’s picture

boombatower commented
Status: Needs review » Fixed

Committed.

Thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.