In the issue Darker blue color for :hover & :active, we discovered that the value of --color-absolutezero-active was not the same as it is set in the design specs.
This has been fixed, but it is possible that other color values are still incorrect.
| Comment | File | Size | Author |
|---|---|---|---|
| #32 | 3085109-31.patch | 3.66 KB | smustgrave |
| #32 | interdiff-29-31.txt | 2.03 KB | smustgrave |
| #21 | 3085109-21-REROLL.patch | 6.26 KB | bnjmnm |
| #18 | 3085109-18.patch | 64.5 KB | himanshu_sindhwani |
| #11 | claro-color_values-3085109-11.patch | 64.7 KB | lokarkristina |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
ant1I updated some of the comments, according to what I've found in the design specs.
Comment #3
saschaeggiI just had a look at the patch and can verify that the variables for absolute-zero are now congruent to the Design System, thanks!
Comment #4
saschaeggiComment #5
saschaeggiComment #6
lauriii@saschaeggi pointed out on PM that we don't use the mathematically correct values for the absolute-zero-hover and absolute-zero-active because they would tend to a violet tone. We should document that here as well.
Comment #7
ant1Updated the comments for
--color-absolutezero-hover&--color-absolutezero-active.Comment #8
ant1Comment #9
huzookaComment #10
ant1Rerolled.
Comment #11
lokarkristina commentedI updated the color-absolutezero and color-absolutezero-hover to match the designs. I've also updated the color-absolutezero-hover and color-absolutezero-active comments to correct values.
Comment #12
tjasajereb commentedReviewed the latest patch and confirming color--absolutezero, color--absolutezero-hover and color--absolutezero-active are now corrected to match the design files.
Comment #14
asmita26 commentedComment #15
asmita26 commentedVerified and tested by applying patch #11. It was applied successfully. color--absolutezero, color--absolutezero-hover and color--absolutezero-active looks good to me and match with design as well.
Comment #16
lauriiiI think we need a reroll for 9.1.x 🧑🍳
Comment #17
narendra.rajwar27Patch at #10 is getting applied for 9.1.x as well.
(EDIT): Ah i see , i checked for patch #10. :( :(
Comment #18
himanshu_sindhwani commentedReroll for patch at 11 for 9.1.x.
Comment #20
tanubansal commentedPatch #18 is successfully applied for 9.1x
. color--absolutezero, color--absolutezero-hover and color--absolutezero-active looks good and as per design.
Comment #21
bnjmnmComment #22
bnjmnmComment #24
sakthivel m commented#24 Just Re-roll the patch 9.3.x
Comment #28
smustgrave commentedNeeds reroll for D10.1
Comment #29
akram khanAdding updated patch and reroll against 10.1.x
Comment #30
smustgrave commented@Akram Khan seems you removed a number of changes
Comment #31
akram khan@smustgrave No i didn't. Changed only that much required in CSS file.
In 10.1.x CSS file has been changed before in 9.x its hardcoded or directly used the css properties and in 10.1.x properties are used using variables so we need to change only in one variable and properties apply every where it's used. please suggest if i'm wrong.
Comment #32
smustgrave commentedDisregard previous comment I see what was done.
But appears the css wasn't compiled. You can check for CI issues using the script in core/scripts/dev/commit-code-check.sh
Comment #33
nod_Last patch is only changing comments, not the actual color value, is that on purpose?
Kinda lost at what supposed to happen here. Can someone update the IS with a link to claro color palette?
Comment #37
rinku jacob 13 commentedHi nod_, From understanding the issue from the beginning, we need to change the value of --color-absolutezero-active because in the issue(Darker Blue color for hover & active) , @saschaeggi mentions that the hover color should be #0036B1 and the active color should be #00339A. However, based on comment #11, she updated the color codes for both hover and active states according to the Figma design: Despite this, the recent patches haven't updated the active color value. Therefore, I didn't change the active color code. Should we proceed with updating the active color value as well? "I have created a merge request based on the recent patches, which means I only made changes to the hover color. The latest version of Drupal uses #002e9a as the active color value.
Comment #38
rinku jacob 13 commentedComment #39
smustgrave commentedWe should have a summary update for this one.
Probably good to get a sub-maintainer to sign off on changes after a few years.
Comment #41
quietone commentedThe Claro theme was approved for removal in #3576460: [policy, no patch] Deprecate and remove Claro.
This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.
The deprecation work is in #3576668: [meta] Tasks to deprecate Claro and the removal work in #3584638: [meta] Tasks to remove the Claro theme.
Comment #42
smustgrave commentedClaro has moved to contrib