@saschaeggi mentioned we should use a darker blue color for :hover & :active.
also you can have a look here: https://www.figma.com/file/OqWgzAluHtsOd5uwm1lubFeH/Drupal-Design-system...
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | 3083850-15.claro_.Darker-blue-color-for-hover--active.patch | 1.82 KB | fhaeberle |
| #15 | interdiff.3083850.12-15.txt | 800 bytes | fhaeberle |
| #12 | 3083850-12.claro_.Darker-blue-color-for-hover--active.patch | 1.73 KB | fhaeberle |
| #12 | interdiff.3083850.8-12.txt | 711 bytes | fhaeberle |
| #8 | claro-link-colors-3083850-8.patch | 1.2 KB | ant1 |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
compare
Comments
Comment #2
saschaeggiLinks should use the same colors for :hover and :active as the buttons.
Comment #3
ant1Added patch for changing of link colors on :hover & :active states.
I did notice that the Absolute Zero Active color of the design system is different of the one in the theme itself.
Should we create a follow-up adressing this issue?
Comment #4
saschaeggi@antoineH What color is defined for active?
Comment #5
ant1--color-absolutezero-active: #00309e; /* 10% darker than base. */Comment #6
saschaeggiOriginally we specified that hover is 10% darker and active 20% darker than the base. But maybe @ckrina or @lauriii can step in to clarify. I just don't remember why it might made sense ;-)
Comment #7
lauriiiComment #8
ant1Comment #9
fhaeberlePatch looks good and applies. Thank you! We are still using the old active color value
#00309einstead of the "new"#00339asuggested in this issue summary.Can somebody from the design team verify this?
Comment #10
saschaeggiThanks @fhaeberle. I'm not aware of why it's different but will verify it if I just missed something. Will get back to your question asap.
Comment #11
saschaeggi@fhaeberle use the one specified in the Design System (the one in screenshot) please.
Comment #12
fhaeberleThanks! This patch adds the new active color also.
Comment #13
ant1Shouldn't we also update the comments, as
#00339aisn't 10% but 20% darker than the base color?Comment #14
lauriii+1
Comment #15
fhaeberleSorry, I accidentally missed those. Changed now.
Comment #17
lauriiiLooks good. Thank you! 🙏