Follow-up to #507488: Convert page elements (local tasks, actions) into blocks

Problem/Motivation

It's best practice to name regions based on their placement on the page, rather than the content that is expected within them. Blocks can be placed in any region. #2513526: Rename the menu regions demonstrates the usability implications, with some users confusing the region with the block.

Proposed resolution

Remove the breadcrumb region and move the breadcrumb block to the precontent region

Remaining tasks

Write a patch
Review

User interface changes

No more breadcrumb region for Seven

API changes

None

Data model changes

None

CommentFileSizeAuthor
#33 2561671_33.patch4.86 KBameymudras
#28 Screenshot from 2021-05-25 14-40-28.png29.77 KBmarcusvsouza
#28 after-patch-seven.png91.04 KBmarcusvsouza
#26 After Patch 2561671.png354.56 KBchetanbharambe
#26 Before Patch 2561671.png368.16 KBchetanbharambe
#23 2561671-after_patch-22.png64.12 KBabhijith s
#23 2561671-before_patch-22.png68.36 KBabhijith s
#22 interdiff_21-22.txt630 bytesraman.b
#22 2561671-22.patch4.74 KBraman.b
#21 interdiff_18-21.txt3.18 KBraman.b
#21 2561671-21.patch4.79 KBraman.b
#20 interdiff_18-20.txt3.16 KBraman.b
#20 2561671-20.patch5.01 KBraman.b
#18 2561671-18.patch2.53 KBkomalk
#2 2561671-2.patch2.95 KBwim leers

Comments

LewisNyman created an issue. See original summary.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review
Issue tags: +Needs tests
StatusFileSize
new 2561671-2.patch2.95 KB

Upgrade path included, but I suspect this will need tests still.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented 
+++ b/core/profiles/standard/config/install/block.block.seven_breadcrumbs.yml
@@ -1,9 +1,9 @@
-weight: 0
+weight: -10

This is wrong. I first thought that the breadcrumb should appear above the tabs, but apparently that's not true. I fixed my the update hook, but I forgot to update this again.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Issue tags: -Needs tests +Needs upgrade path tests 
+++ b/core/modules/system/system.install
@@ -1440,6 +1440,20 @@ function system_update_8005() {
+ * Move the Breadcrumbs block in the Seven theme to the 'pre_content' region.
+ */
+function system_update_8006() {

This can be moved to the block module. Otherwise patch looks good. We still need test coverage for this.

lewisnyman’s picture

lewisnyman
he/him
commented
Status: Needs review » Needs work

I manually test the patch and the upgrade path and it works no problem. Setting to needs work for tests.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Can/should this still happen during RC?

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Version: 8.2.x-dev » 9.x-dev
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 9.x-dev » 8.3.x-dev

Seven has been marked as internal. For that reason I think this could be still worked in Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

komalk’s picture

komalk commented
StatusFileSize
new 2561671-18.patch2.53 KB

Re-rolled the patch against the 9.1.x

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

raman.b’s picture

raman.b commented
Status: Needs work » Needs review
Issue tags: -Needs upgrade path tests
StatusFileSize
new 2561671-20.patch5.01 KB
new interdiff_18-20.txt3.16 KB

Addressing #4 and resolving failed test case from #18

raman.b’s picture

raman.b commented
StatusFileSize
new 2561671-21.patch4.79 KB
new interdiff_18-21.txt3.18 KB

Addressing #4 and resolving failed test case from #18

Accidently included .DS_Store in #20. Uploading the patch again.

raman.b’s picture

raman.b commented
StatusFileSize
new 2561671-22.patch4.74 KB
new interdiff_21-22.txt630 bytes
abhijith s’s picture

abhijith s commented
StatusFileSize
new 2561671-before_patch-22.png68.36 KB
new 2561671-after_patch-22.png64.12 KB

Patch #22 works fine .the breadcrumb region is removed .But the breadcrumb block is placed at header region and will be disabled after after applying this patch
Adding screenshots
Before patch:
before
After patch:
after

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

chetanbharambe’s picture

chetanbharambe commented
Assigned: Unassigned » chetanbharambe
chetanbharambe’s picture

chetanbharambe commented
Assigned: chetanbharambe » Unassigned
Status: Needs review » Reviewed & tested by the community
Issue tags: +RTBC
StatusFileSize
new Before Patch 2561671.png368.16 KB
new After Patch 2561671.png354.56 KB

Verified and tested patch #22.
Patch applied successfully and looks good to me.

Testing Steps:
# Goto: admin/structure/block
# User is able to see Breadcrumb region in Seven themes.

Expected Results:
# User should not see Breadcrumb region in Seven themes.

Actual Results:
# User is able to see Breadcrumb region in Seven themes.

Looks good to me.
Can be a move to RTBC.

chetanbharambe’s picture

chetanbharambe commented
Issue tags: -RTBC
marcusvsouza’s picture

marcusvsouza commented
StatusFileSize
new after-patch-seven.png91.04 KB
new Screenshot from 2021-05-25 14-40-28.png29.77 KB

The patch applies without problems and works as expected.
I found this two warnings in the file MoveBreadcrumbsBlockTest.php, both lines are comments.
8 | WARNING | Line exceeds 80 characters; contains 86 characters
32 | WARNING | Line exceeds 80 characters; contains 88 characters

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs work

Seven is on its way towards being replaced with Claro before too long, so I'm not sure about refactoring at this point.

Additionally, the upgrade path affects the breadbrumbs block, but nothing stops someone putting other blocks in this region too.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: Remove the breadcrumb region in Seven » Remove the breadcrumb region
Component: Seven theme » Claro theme

Claro, Olivero and Umami themes also all have "breadcrumb" regions.

Moving this to Claro first to decide whether this is still an issue, if so we probably need separate issues for each core theme.

ameymudras’s picture

ameymudras commented
Status: Needs work » Needs review
StatusFileSize
new 2561671_33.patch4.86 KB

Refactored the above patch for Claro theme and moved the breadcrumb region blocks to highlighted region.

Status: Needs review » Needs work

The last submitted patch, 33: 2561671_33.patch, failed testing. View results

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Status: Needs work » Postponed
Issue tags: -frontend

The Claro theme was approved for removal in #3576460: [policy, no patch] Deprecate and remove Claro.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3576668: [meta] Tasks to deprecate Claro and the removal work in #3584638: [meta] Tasks to remove the Claro theme.

smustgrave’s picture

smustgrave commented
Project: Drupal core » Claro
Version: main » 3.0.x-dev
Component: Claro theme » Code
Status: Postponed » Postponed (maintainer needs more info)

Claro has moved to contrib

But am questioning if this is something we should even consider doing..