Since this seems somewhat stable --- i.e., it hasn't undergone any major changes in a while --- perhaps it should be included with the regular CAS module?

Comments

bkosborne’s picture

bkosborne
Primary language English
Location New Jersey, USA
commented
Issue summary: View changes

I for one prefer having the functionality separate :). I think many people have no need to use any CAS/LDAP attributes for their SSO solution.

olarin’s picture

olarin commented

Perhaps it would make sense for it to become a sub-module of the CAS project in the D8 version?

yalet’s picture

yalet commented

I can see both sides of this. On the one hand, given that d8 CAS module is not (currently) using phpCAS as its protocol implementation, and instead using a native Drupal / GuzzleHttp implementation, in order for this to work at all, CAS module must be "attribute-aware" and parse out attributes during validation. This is already in place. So at some level, CAS module is already dealing with attributes.

On the other hand, CAS module doesn't do anything with them except offer them up as data when it dispatches its events. The event dispatching is really clean, so I don't think there's too much benefit to rolling the attributes to field mapping into the CAS module itself, as it will be implemented the same either way.

It comes down to project distribution, and I feel the same bkosborne does: there are people who use CAS who have no use for attribute mapping, so there's no reason for them to have code lying around that won't do anything.