Needs review
Project:
Drupal Canvas
Version:
1.x-dev
Component:
Page builder
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
1 Oct 2024 at 06:44 UTC
Updated:
12 Jun 2025 at 05:52 UTC
Jump to comment: Most recent
Show commands
changes
Comments
Comment #2
utkarsh_33 commentedComment #5
cosmicdreams commentedI've added the code change I was talking about in the Gitlab discussion. I wonder, does pressing 'Command + D' actually duplicate the element?
The next test fails to measure that there are two elements present where there was once one. It times out. Is it stalling because it's trying to look for the duplicate but it's not there yet?
Comment #6
cosmicdreams commentedMy theory was that the duplication test needed the same steps / structure as the delete test. But waiting for the preview to be ready did not fix the test.
I'm left wondering if the component duplication logic is what is not working.
Comment #7
utkarsh_33 commentedI tested this and this works when we try to duplicate a component using the contextual menu dropdown.
I think the problem is with the key Events, which seems not to be working but i am unsure why is that happening as i can duplicate the components using the keyboard shortcuts on my local.I'll try to dig more into this.Thanks!
Comment #8
utkarsh_33 commentedAssigning it to @jessebaker for suggestions.
Comment #9
utkarsh_33 commentedAssigning it to me because i think i got the solution.
Comment #10
utkarsh_33 commentedJust a small question that needs clarification, so marking it NR.
Comment #11
bnjmnmAdded a suggestion on how to avoid
wait()Comment #12
utkarsh_33 commentedI added a better way of asserting that the hero component is added to correct place.
Comment #13
utkarsh_33 commentedComment #14
bnjmnmSee MR
Comment #15
parthbcharya commentedComment #18
parthbcharya commentedComment #19
wim leersNo longer applies 🙈
Comment #20
parthbcharya commentedComment #22
drupalbabaji commentedComment #23
deepti_naik commentedComment #24
omkar-pd commentedI see 0 changes in PR.
Comment #25
drupalbabaji commentedI had to revert the changes, which is done in https://www.drupal.org/project/experience_builder/issues/3477957#mr775-n... . So i think thats why there is 0 changes in PR.
https://www.drupal.org/project/experience_builder/issues/3477957#comment...
Comment #26
drupalbabaji commentedComment #27
jessebaker commentedThere are no changes to review in the MR, all previous changes have been reverted so something has gone awry here I think. Can you take another look @drupalbabaji
Comment #28
drupalbabaji commented@Jessebanker as per comment https://www.drupal.org/project/experience_builder/issues/3477957#comment... . It says "No longer applies" and need a re-roll. I think we can close the open MR after confirmation with Wim leers.
Comment #29
drupalbabaji commented