Problem/Motivation

Bootstrap 4 is now widely used, but this module does not work with BS4. The version of Bootstrap supported by this module should be clearly listed on the module description and README.

CommentFileSizeAuthor
#7 bootstrap_paragraphs-3172008-interdiff-5-7.txt1.04 KBWebbeh
#7 bootstrap_paragraphs-3172008-7.patch1.51 KBWebbeh
#5 3172008-5.patch1.51 KBPooja Ganjage
#2 3172008-2.patch1.51 KBPooja Ganjage

Comments

lunk rat created an issue. See original summary.

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3172008-2.patch1.51 KB

Hi,

I am applying patch for this issue.

Let me know for any recommendations.

Kindly review the patch once.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Active » Needs review
lunk rat’s picture

lunk rat commented
Status: Needs review » Needs work

The patch in #2 changes the info.yml file to merely state that this module works with Bootstrap 4. However, I don't think this is true, as per #2861474

So it appears that Bootstrap_paragraphs DOES NOT WORK WITH BOOTSTRAP 4.

I think this patch needs to be changed to state the actual supported version of Bootstrap compatible with this module.

Pooja Ganjage’s picture

Pooja Ganjage commented
StatusFileSize
new 3172008-5.patch1.51 KB

Hi,

I am creating patch as per the #4 comment suggestions.

Please review the patch.

Thanks.

Pooja Ganjage’s picture

Pooja Ganjage commented
Status: Needs work » Needs review
Webbeh’s picture

Webbeh
he/him/his
Location Georgia, USA
commented
StatusFileSize
new bootstrap_paragraphs-3172008-7.patch1.51 KB
new bootstrap_paragraphs-3172008-interdiff-5-7.txt1.04 KB

Typo in #5. 'Boostrap' should be 'Bootstrap'.

I also appended the URL change in #5 to be more explicit in the link text it links to 3.3.x documentation.

thejimbirch’s picture

thejimbirch commented
Status: Needs review » Closed (won't fix)

There may be some bugs with the Accordion using Bootstrap 4, but the module works with version 3 or 4 of Bootstrap currently and we can look at Bootstrap 5 when it has a full release.

Thanks for the patch, but I am going to close this as Won't Fix.

lunk rat’s picture

lunk rat commented
Status: Closed (won't fix) » Fixed

I opened this issue because I wanted this module's web page to clearly state the supported BS version. As of today, it does:

The Bootstrap Paragraphs module provides a suite of content and layout Paragraph bundles made with the Bootstrap (3.x or 4.x) front-end framework.

So marked fixed. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.