Problem/Motivation

Found this when guiding a client to setup a carousel.

We had configured a multi value image field, and a multi value link field. With slick image field formatter we selected the Media switcher to be "Image linked by Link field" and the Link to be the multi value link field.

Our assumption was that if we had 5 images and 5 link values, that each delta would link to the corresponding link field delta. Only the first link value was used to link all images.

I saw there is a todo in the code - but I could not find a related issue for this feature request.

// @todo enable $delta = $blazies->get('delta');
/ @todo add option to map links to images.

Steps to reproduce

Proposed resolution

Use the delta when linking - I am not sure if this needs to be configured via another option, I guess if somebody is reusing a field for a different purpose adding this could cause regression unless it has another config flag to enable?

Remaining tasks

  • Decide if this needs an explicit config flag
  • Implement

User interface changes

TBC

API changes

N/A

Data model changes

N/A

Issue fork blazy-3612896

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ericgsmith created an issue. See original summary.

ericgsmith opened merge request !32

ericgsmith’s picture

ericgsmith commented

Added MR which shows the todo and from a quick test achieves what the client and I thought would be how the setting worked.

Needs maintainer input for adding additional config to check delta, and eventually test coverage when we have a clearer plan.

  • gausarts committed 466a7c08 on 4.0.x 
    feat: #3612896 Use field delta for "Image linked by Link field" in media...
gausarts’s picture

gausarts commented
Status: Active » Fixed

I haven't checked other use cases with more complex setups: Paragraphs, Views, etc.

If any issues, we can always revisit this later.

Thanks for your contribution.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.