Make #282996: FileField support for Biblio? configurable? There are cases where some attached files are out of context in the biblio search results - whether core upload or filefield.
This patch adds a new configuration to the biblio main settings - defaulting to 'Display files' - the files can now be hidden by un-checking this setting.

CommentFileSizeAuthor
#1 biblio_526740.patch2.48 KBscottrigby

Comments

scottrigby’s picture

scottrigby
he/him
Primary language English
Location Brooklyn, NY
commented
StatusFileSize
new biblio_526740.patch2.48 KB

patch attached

scottrigby’s picture

scottrigby
he/him
Primary language English
Location Brooklyn, NY
commented
Status: Active » Needs review

:p

rjerome’s picture

rjerome commented

How does this differ from the biblio user permission "show download links" on the admin/user/permissions page?

scottrigby’s picture

scottrigby
he/him
Primary language English
Location Brooklyn, NY
commented
Status: Needs review » Closed (fixed)

Hi Ron,
The main difference is... the existing permissions are better! I can't believe i missed that

Initially I looked in biblio_theme.inc and the only access check i saw in theme_biblio_download_links() was 'view uploaded files' - the other permissions must be called from elsewhere & so I just missed em.

The reason i went the route of adding a new config to the settings form is it seemed in line with the way other elements (like links) are configured to display - but permissions are actually better for files, so ... thanks :)

Good luck with the rest of the port ("bibliographizing" cck fields etc)

aren cambre’s picture

aren cambre commented
Status: Closed (fixed) » Closed (duplicate)

Also duplicated by #682044: Support fields (CCK) in D7 Bibliography Module. :-)