Problem/Motivation
see https://git.drupalcode.org/project/automatic_updates/-/merge_requests/60...
We may want to use for kernel tests also
But we don't have access to the stage directory in functional tests so it is currently more complicated
Steps to reproduce
Proposed resolution
TBD
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork automatic_updates-3322913
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
wim leersComment #3
wim leersHopefully this too 🤞
Comment #4
wim leersThis seems related?
Comment #6
tedbowThis is rough start now to see how this might work.
This relies on trait being shared between a test module and test classes which I am not sure is good idea or can even work. But it does provide the same way to simulate stage changes, updates, adds and removals, in both kernel and functional tests. And removes the need for listeners in kernel tests to make these changes which is complicated and not easy to understand.
Comment #7
wim leersLeft a bunch of questions to hopefully help shepherd this in a good direction 🤞
Comment #9
tedbowUnassigning for myself
@Wim Leers if you want to review that would be good but if you want to wait till I can work on it thats fine to. Feel free to unassign back to me if you would rather
Comment #10
wim leersResponded to all your MR comments 🤓
Comment #13
tedbowassigning to @Wim Leers to get feedback on https://git.drupalcode.org/project/automatic_updates/-/merge_requests/60...
Comment #14
wim leersComment #16
tedbowComment #17
tedbow@Wim Leers thanks for the long pairing on this.
I started what we discussed. Probably some test with fail. Feel free to look it over to make sure it is what you had in mind. Otherwise I will assign back to myself next time I have a chance to work on it.
Comment #18
wim leers🤩
Pushed commits that should make this green — the good news is that the test failures force us to structure the tests just as we had discussed! 👍🥳
IMHO this now just needs cleaning up. Either you can do that today and I review it on Monday, or I can do that early on Monday. Either way, we should able to land this on Monday! 😊
Comment #19
tedbowComment #20
wim leersComment #21
tedbowSee MR comments
Comment #22
wim leers11 remarks on the MR: a bunch of nits, and just a few celebrations 🤩😄
Comment #23
tedbow@Wim Leers thanks. Fixed nits. will merge when green
Comment #25
tedbow😁🎉
Comment #26
wim leersYay! Unpostponed #3321904: Remove automatic_updates_extensions/tests/fixtures/stage_composer in favor of using StageFixtureManipulator 👍
Comment #27
tedbowComment #28
wim leersFollow-up improvement after real-world experience with this new infrastructure: #3327391: Improve FixtureManipulator DX: validate package name + ensure StageFixtureManipulator is committed + ensure `package_manager_bypass_composer_stager` is not set to FALSE.