Attached is a patch I put together which upgrades the Advanced Poll Converter to Drupal 6. I ran it on a site I'm putting together with ~1300 polls and it appears to have worked well, although I only spot-checked it. Still needs some closer review and testing.

CommentFileSizeAuthor
#6 357386_convert_upgrade_6..patch4.62 KBgdd
#4 advpoll_convert_6_upgrade.patch4.66 KBgdd
advpoll_convert_6_upgrade.patch4.5 KBgdd

Comments

ChrisKennedy’s picture

ChrisKennedy commented

1300 polls... not too shabby :P Thanks for working on this. In the last modification did you have a reason for taking out the IP placeholder for manual votes?

gdd’s picture

gdd
he/him
Primary language English
Location Portland, OR
commented

Yeah I'm bringing an existing site into Drupal, and it has a lot user-generated content including polls that include HTML in the choices, which is what led me to advpoll.

The new votingapi_votes table doesn't include the hostname field anymore, so I pulled that out of the queries.

ChrisKennedy’s picture

ChrisKennedy commented

Well it just got renamed to vote_source actually, to be a little more generic.

gdd’s picture

gdd
he/him
Primary language English
Location Portland, OR
commented
StatusFileSize
new advpoll_convert_6_upgrade.patch4.66 KB

Ah hah! I did kind of whip through this pretty quick. New patch attached which restores the IP placeholder and renames the field in votingapi_votes.

ChrisKennedy’s picture

ChrisKennedy commented
Status: Needs review » Needs work

I tested it out and db_next_id() doesn't exist in D6 - see http://drupal.org/node/114774#db_last_insert_id . Looks like we need to either use drupal_write_record, or more cleanly, votingapi_add_votes().

gdd’s picture

gdd
he/him
Primary language English
Location Portland, OR
commented
Status: Needs work » Needs review
StatusFileSize
new 357386_convert_upgrade_6..patch4.62 KB

Actually we don't need that at all anymore since D6 uses autoincrement fields to generate keys rather than db_next_id(). I don't know how I left that in, I'm sure I had removed it. Anyways, new patch attached.

ChrisKennedy’s picture

ChrisKennedy commented
Status: Needs review » Fixed

Thanks, committed - http://drupal.org/cvs?commit=171793

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.