Drupal 8.0.2 on Pantheon
From:
/admin/config/development/performance/advagg
I disable the checkbox for "Enabled advanced aggregation" and hit "Save configuration."
This results in the following error:
The website encountered an unexpected error. Please try again later.
Recoverable fatal error: Argument 2 passed to advagg_bundler_advagg_setting_form_submit() must be an instance of FormStateInterface, instance of Drupal\Core\Form\FormState given in advagg_bundler_advagg_setting_form_submit() (line 31 of modules/advagg/advagg_bundler/advagg_bundler.module).
I can go back and reload the page, but the value has not been saved (it is still enabled).
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | advagg-2659322-10-formStateInterface.patch | 722 bytes | mikeytown2 |
| #2 | advagg-cannot-enable-or-disable-advanced-aggregation-2659322-1-8.patch | 685 bytes | irishdan |
Comments
Comment #2
irishdan commentedBy removing the type hinting on the advagg_bundler_advagg_setting_form_submit the form can be submitted without error.
Comment #3
irishdan commentedComment #4
irishdan commentedComment #6
chandeepkhosa commentedComment #7
mikeytown2 commentedretesting #2
Comment #8
digitaldonkey commentedPatch (advagg-cannot-enable-or-disable-advanced-aggregation-2659322-1-8.patch) worked for me. Thx.
Comment #9
freality commentedThe issue is namespacing. Adding
use \Drupal\Core\Form\FormStateInterface;to the top of the file. Or changing the function signature tofunction advagg_bundler_advagg_setting_form_submit(array &$form, \Drupal\Core\Form\FormStateInterface &$form_state)resolves the issue without removing the type-hinting.The file being advagg_bundler.module.
Comment #10
mikeytown2 commentedLooks like advagg now fails the PHP 7 branch without any patches. Created this issue #2722809: PHP 7 Compatibility with advagg 8.x-2.x
Comment #12
mikeytown2 commentedGoing to go ahead and mark this as fixed. Will look into the PHP 7 issues in the other thread. Thanks for the help here!
Comment #14
mikeytown2 commented