Problem/Motivation

Please see: #3567667: Deprecate Stable9

Steps to reproduce

Proposed resolution

I tried using https://www.drupal.org/project/bootstrap5 as the base theme, and it seems to have improved things.
Of course, there are alternative Bootstrap base themes to consider, but Bootstrap5 seems fine. It's not bloated with SDCs (nothing against SDCs, but I don't think we will benefit from them in this project), etc., and it's pretty straightforward.

Remaining tasks

  • [x] Replace base them in info file
  • [ ] Remove duplicate theme settings
  • [ ] Alter theme setting for theme mode 'auto' (BS5 theme only provides dark and light)
  • [ ] Unset further not required settings from the BS5 theme
  • [x] The Bootstrap Lib is loaded twice, disable the BS5 theme library in adminlte.info.yml:

    libraries-override:
      bootstrap5/global-styling: false
      bootstrap5/bootstrap5-js-latest: false
        
  • [x] Override the bootstrap5 themes ckeditor_stylesheets (info file).
  • [x] Add Dependency (composer.json / .info)

User interface changes

API changes

Data model changes

Issue fork adminlte-3609244

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

    Comments

    thomas.frobieter created an issue. See original summary.

    anybody’s picture

    #3608934: Add important Drupal base css from a starterkit theme is unresolved and would be resolved this way, at least for now. The bootstrap5 theme would build the foundation and reduce the need for managing all these templates.

    Still in the future it could also cause issues, so for the maintainer to decide if this is the final solution, but at least me might use it as basis for 1.x and then decide if 2.x should instead implement all the specific template files itself (by copy).

    Please note that also settings are inherited and would need to be addressed.

    There are pro's and con's but I think in the end this is much better than building all the foundation ourselves again!

    thomas.frobieter’s picture

    Issue summary: View changes
    thomas.frobieter’s picture

    Issue summary: View changes
    thomas.frobieter’s picture

    Issue summary: View changes
    anybody’s picture

    BTW bootstrap5 is generally made as base-theme, it also has a child-theme generator in the theme settings!

    thomas.frobieter’s picture

    Issue summary: View changes
    anybody’s picture

    Okay I'd definitely vote to do this for 1.x!

    I created #3609256: [Discuss][2.x] Maybe decouple from bootstrap5 theme and copy relevant elements? as follow-up to re-evaluate how this worked out later for 2.x.

    thomas.frobieter’s picture

    Issue summary: View changes
    thomas.frobieter’s picture

    The combination with the bootstrap5 theme as base theme still looks very good to me.
    After removing the duplicate library files using:

    libraries-override:
      bootstrap5/global-styling: false
    

    Things look very nice. This way, we benefit from the Drupal-specific Bootstrap5 theme styles and the Bootstrap-specific template tweaks. Meanwhile, AdminLTE sticks with its customized Bootstrap Lib.

    thomas.frobieter’s picture

    Issue summary: View changes
    anybody’s picture

    @thomas.frobieter thanks - will you prepare a MR here finally?

    thomas.frobieter’s picture

    Issue summary: View changes
    thomas.frobieter’s picture

    Issue summary: View changes
    anybody’s picture

    Assigned: Unassigned » thomas.frobieter

    • silkalns committed 3247e1a2 on 1.0.x
      #3609244: rebase theme onto Bootstrap5 base theme (drop deprecated...
    anybody’s picture

    Status: Active » Needs review

    @thomas.frobieter further changes needed? See the commit here for the diff.

    thomas.frobieter’s picture

    Issue summary: View changes
    Status: Needs review » Needs work

    I've highlighted the completed items in the assignment text.

    anybody’s picture