Problem/Motivation

Not best practice to use the procedural t() in OOP Code.
File: adminimal_admin_toolbar/src/Form/SettingsForm.php
See:
https://www.drupal.org/docs/8/api/translation-api/overview
https://api.drupal.org/api/drupal/core%21includes%21bootstrap.inc/function/t/8.6.x

Proposed resolution

Use $this->t();

Remaining tasks

  1. Create patch
  2. Review/RTBC
  3. Commit

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 adminimal_admin_toolbar-fixed_t-3027760-2.patch685 bytesi-trokhanenko

Comments

i-trokhanenko created an issue. See original summary.

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Assigned: i-trokhanenko » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new adminimal_admin_toolbar-fixed_t-3027760-2.patch685 bytes
energee’s picture

energee commented
Status: Needs review » Reviewed & tested by the community

  • energee committed 2945c29 on 8.x-1.x authored by i-trokhanenko 
    Issue #3027760 by i-trokhanenko: Use $this->t() instead of t() in form
energee’s picture

energee commented
Status: Reviewed & tested by the community » Fixed
i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Issue summary: View changes

thanks @energee

energee’s picture

energee commented

:)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.