After this change, the Drupal icon overlaps the icon set on the /admin/appearance/settings page or in the icon set in the theme settings.
Please fix it.
https://www.drupal.org/project/admin_toolbar/issues/3158374

-

CommentFileSizeAuthor
#3 2020-10-14 233631.png23.25 KBdd 85
2020-10-07 220546.png20.89 KBdd 85

Comments

DD 85 created an issue. See original summary.

romainj’s picture

romainj commented

@DD 85 could you provide a screenshot please? I see nothing like this on my D8 test site.

dd 85’s picture

dd 85 commented
StatusFileSize
new 2020-10-14 233631.png23.25 KB

Upload your image on the /admin/appearance/settings page

-

Clear the cache and go to the main page. Look at the CSS code of the icon located in the administrative menu.
You will see

-

skaught’s picture

skaught
Primary language English
commented
Related issues: +#3177269: Missing box-sizing attributes on the toolbar-icon
skaught’s picture

skaught
Primary language English
commented
Parent issue: » #3158374: Show Drupal Icon depending on which drupal major version it is.
adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented

@DD 85 can you check if the patch in #3177269: Missing box-sizing attributes on the toolbar-icon fix your problem?

dd 85’s picture

dd 85 commented

No, this is not a solution to the problem.
Because a CSS rule with a class .toolbar-icon-8 has priority over the same rules without this class.

The rule .toolbar-icon-admin-toolbar-tools-help::before is used by a large number of themes. Adding a class .toolbar-icon-8 in the CSS of the admin_toolbar module requires editing the styles of all themes that have a rule .toolbar-icon-admin-toolbar-tools-help::before I think this is too large. It's easier to cancel adding a class .toolbar-icon-8 in the admin_toolbar module and find another solution for displaying the logo with the Drupal version.

skaught’s picture

skaught
Primary language English
commented

can you show an inspection of the html that is in that and how this psedo class is effecting this element if it doesn't have a 'toolbar' class on it.

skaught’s picture

skaught
Primary language English
commented

'.toolbar-icon-admin-toolbar-tools-help' being the first icon when Admin Toolbar is enabled (and is added by Admin Toolbar) -- this module does have the sway to use this this way. Some truth is that it may take some time for other contrib themes to catchup to this new feature..

but again, we can not seem to recreate any error, nor can we see from that screen shot how anything is broken.

QUESTIONS

  1. would you attach your 'front page' screen shot after you 'add your icon' as you have noted above.
  2. did you use the fields for 'path to cusotm icon' or 'upload favicon image' ?, or both?
  3. what is your public theme?
dd 85’s picture

dd 85 commented

Styles from the module with background-image overlap similar styles from the theme. This can be seen in the attached screenshot.
I use path to cusotm icon. I assume that with upload favicon image will be the same.
Public theme Bartik 8.9.7

michfuer’s picture

michfuer commented

I ran into this same issue updating this module from 8.x-1.20 to 8.x-2.4. Was seeing .toolbar-icon-8 class being added to the <body> tag
from https://git.drupalcode.org/project/admin_toolbar/-/commit/46ca3837f2e118...

and the custom admin theme icon which was targeting .toolbar-icon-admin-toolbar-tools-help::before was being overridden by the module's default D8 icon.

Updating the custom theme to .toolbar-icon-8 .toolbar-icon-admin-toolbar-tools-help::before {} did the trick.

I would expect a custom icon set in a core/contrib theme to take precedent, but not sure how best to do that here.

dydave’s picture

dydave commented
Status: Active » Closed (outdated)

No activity on issue for more than 4 years.
Closing: outdated.

Thanks!