i'm working on a project that is D8 (summer2020). have just updated to admin toolbar 2.3 which is release for core 8||9. the icon shows the current drupal 9 logo. This is confusing project admin/owners..

can we work in the core version to show an icon that won't confuse none developers..

CommentFileSizeAuthor
#6 Screen Shot 2020-08-04 at 12.49.35 PM.png192.16 KBskaught
#3 #3158374_3-Core_icon_based_on_magor.patch4.62 KBskaught
Screen Shot 2020-07-10 at 2.14.15 PM.png65.84 KBskaught

Comments

SKAUGHT created an issue. See original summary.

adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Assigned: Unassigned » adriancid

Thanks for reporting, try to use the next time the Issue Summary Template.

I will make this change soon.

skaught’s picture

skaught
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new #3158374_3-Core_icon_based_on_magor.patch4.62 KB

  • adriancid committed 46ca383 on 8.x-2.x authored by SKAUGHT 
    Issue #3158374 by SKAUGHT: Show Drupal Icon depending on which drupal...
adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented
Status: Needs review » Fixed

Thanks

skaught’s picture

skaught
Primary language English
commented
Issue summary: View changes
StatusFileSize
new Screen Shot 2020-08-04 at 12.49.35 PM.png192.16 KB

have realized comment is useless.

skaught’s picture

skaught
Primary language English
commented
Issue summary: View changes

  • adriancid committed 4dc9122 on 8.x-2.x 
    Issue #3158374 by SKAUGHT, adriancid: Show Drupal Icon depending on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

dd 85’s picture

dd 85 commented

After this change, the Drupal icon overlaps the icon set on the /admin/appearance/settings page or in the icon set in the theme settings.
Please fix it.

skaught’s picture

skaught
Primary language English
commented

This issue is a request for feature issue; as such, it is now closed.

i suggest opening a new 'bug report' for this.

  • attach a screenshot.
  • what admin theme are you using?
adriancid’s picture

adriancid
Primary language Spanish
Location Qc, Canada 🇨🇦
commented

Thanks @SKAUGHT, and @DD 85, yes this issue is closed and released, open a new issue and add all the steps to reproduce the problem.

dd 85’s picture

dd 85 commented

This is not a feature release. Because it worked before this change.
Created https://www.drupal.org/project/admin_toolbar/issues/3175604

idebr’s picture

idebr commented 
+++ b/admin_toolbar_tools/css/tools.css
@@ -14,5 +14,18 @@
+.toolbar-icon-8 .toolbar-icon-admin-toolbar-tools-help:before {
+  background-image: url(../misc/icons/ffffff/drupal-8-logo.svg);
+  padding-bottom: 0;
+  padding-left: 4px;
+  padding-right: 8px;
+  padding-top: 2px;
+}

This selector is missing the box-sizing: content-box; from its original code. As a result, the icon has incorrect dimension in various custom themes. This is being fixed in #3177269: Missing box-sizing attributes on the toolbar-icon

skaught’s picture

skaught
Primary language English
commented
Related issues: +#3177269: Missing box-sizing attributes on the toolbar-icon

it is a lot of concern round a standard css defect.. i do understand (:
just a reminder: issues can be related.