Loss of dropdown when enabling admin_toolbar_tools

Hi @Christopher Riley thanks for reporting, can you use the next time the Issue Summary Template?

I can't reproduce the issue, can you add steps?

See the image, is working fine for me.

@Christopher Riley can you test the patch submitted in #2925327: Better check for is-link-in-admin-menu for local task links to see if fix the problem?

Hi,

I get this problem too since updating from 1.20 -> 1.21. None of the drop downs work. If I uninstall admin_toolbar_tools it almost goes back to working perfectly except that the Appearance, Extend and People menus still don't have drop downs. All the others do.

Notable also that the styling changed slightly. When it's working there are border lines between the menus. When it's not it's using a plain black background. with no border lines.

The patch didn't seem to make any difference either with the admin_toolbar_tools module enabled or not.

Reverting to 1.20 fixes the problem.

I think that there might be two separated issues being disscused here.
On one hand, we have the problem of all dropdowns being disabled when admin_toolbar_tools is enabled

and on the other hand the missing dropdowns on Appearance, Extend and People mentioned by @specky_rum
which if I understand correctly with admin_toolbar_tools disabled, that's not really a bug
it's just that the options that would appear under those elements are the links that the admin_toolbar_tools module is supposed to add, the administration menu doesn't have any items under those elements by default

but I'm getting that same behaviour (no dropdowns on Appearance, Extend and People) WITH admin_toolbar_tools installed (the other items are working fine)

I'm getting this two issues only on 8.x-1.x-dev branch (both work ok for me when using 8.x-1.21)

to reproduce the fist issue (no dropdowns) do:

1. get a clean D8 install (or a installation where admin_toolbars is not installed)
2. get version 8.x-1.x-dev of admin_toolbar
3. go to extend and install admin_toolbar_tools (this will force the installation of admin_toolbar)

You will expect to have dropdowns on all items, but none of them will appear

Also, I've found that if you

• on a clean install, first install admin_toolbar and after it completes the install, install admin_toolbar_tools
• or after you installed the two modules together, uninstall admin_toolbar_tools and install it again

this will fix Structure, Configuration and Reports tabs but not the others (Appearance, Extend and People)
so, I think there's another issue here, probably closely related but not exactly the one that was originally reported on this issue
I've created a separated issue for it: admin_toolbar_tools is not creating links on Appearance, Extend and People when installed.

the patch on #2925327: Better check for is-link-in-admin-menu for local task links doesn't seems to affect any of this (tried all this with and without it without seeing any change)

Reverting to 1.20 please!!!.

@kvantstudio you can always use the 1.20 we are trying to find the problem (I will try to reproduce with the steps added by @pedrodacosta) but if you feel that you should use the 1.21 please help us to find the solution.

@pedrodacosta I follow all your steps in a fresh Drupal 8 site but I can't reproduce this issue.

Is described in #2926446: Menu on side loses dropdown

Hi to @all, thanks for your patient and for report the issue with this problematic new version, sorry for this but the module was really working for me and for the others maintainers before the last release, even for other users that test the module before the new release.

As we can't reproduce all the issues reported in the new release version and as it seems that they comes from #2897309: admin_toolbar_tools module makes all pages uncacheable we have removed the code from the actual dev version and we need your help (as you can see the error, but we can't reproduce the issue) to know if now the module is working fine. So please install the latest dev version and provide some feedback about this issue.

As it seems that is a problem with the cache is better handle the problem in #2925501: Menu does not take changes into account (caching issue).

Our sincere apologies and thanks for helping us to improve this module so used by the community.

Somebody can confirm that this is solved in the actual dev?

As I'm not able to reproduce this issue I need a help from us. We are planning a new release in this days.

Hum, your error seems odd. We do not make any use of AJAX callback. It was on a specific page / action or just random ?

Closing because we don't feedback, but you can feel free to reopen in the future :-)

@adriancid I had the same issue as @christopher-riley with the drop downs not appearing and the ajax errors.

Turns out it was the Toolbar Menu module restricting the menu depth, see my comment here for how I was able to fix it:

https://www.drupal.org/project/toolbar_menu/issues/2945706

Not sure if any action is required for this module but just thought I'd post this in case it helps someone else.

In this case, I think that this issue belongs to the login_destination issue queue.

Hi Christopher Riley
I tested the steps you reported and it working as expected.
Christopher Riley could this problem depend on other modules or custom code?

Hey! I just discovered something. When the menu is in the Top, its works,

http://global.josekatech.com/drupal1.png

but when its positioned lateral, I got that 403 error.

http://global.josekatech.com/drupal2.png

I'm using Varbase!

I can confirm that using this module in conjunction with Login Destination causes a conflict. When I uninstall Login Destination, I no longer receive this Ajax error and the vertical toolbar functions properly. I'm using the most recent version of Admin toolbar (8.x-1.26).

I agree with @adriancid that this is likely an issue with Login Destination. Adding the related issue from the Login Destination queue.

I'm closing this issue as it seems the problem comes from Login Destination.