It looks like navbar is going to be an import admin menu module moving forward. I would like to add support so that the site administrators use navbar and the superadmin (me) users admin_menu.

CommentFileSizeAuthor
#8 2085211-support-navbar.patch1.05 KBdave reid
#6 navbar-2085211-6.patch547 bytesdeciphered
#4 admin_select-support-for-navbar-2085211-4.patch2.48 KBjlyon
#3 admin_select-support-for-navbar-2085211-1.patch2.89 KBjlyon

Comments

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Then please help #1728726: Support hook_suppress() to hide the navbar land in the Navbar issue queue. Until that patch is fixed, we cannot support Navbar.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Active » Postponed
jlyon’s picture

jlyon commented
Status: Postponed » Active
StatusFileSize
new admin_select-support-for-navbar-2085211-1.patch2.89 KB

Here's a patch. I movied the hook_page_alter() call from toolbar.inc to system.inc.

jlyon’s picture

jlyon commented
StatusFileSize
new admin_select-support-for-navbar-2085211-4.patch2.48 KB

The patch from #3 gave me a WSOD when I disabled navbar. This patch fixes it and also gets rid of a dpm().

jlyon’s picture

jlyon commented
Status: Active » Needs review
deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Issue summary: View changes
Related issues: +#1728726: Support hook_suppress() to hide the navbar
StatusFileSize
new navbar-2085211-6.patch547 bytes

I also agree with Dave, that this should be dependant on the Navbar issue.

New patch works with Navbar patch.

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
Status: Needs review » Needs work 
+++ b/includes/navbar.inc
@@ -0,0 +1,20 @@
+ * Toolbar module integration.

Damn, missed this...

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs work » Needs review
StatusFileSize
new 2085211-support-navbar.patch1.05 KB

Did come cleanups. This is what I'm about to commit to 7.x-1.x.

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented
Status: Needs review » Fixed

Committed #8 to 7.x-1.x: http://drupalcode.org/project/admin_select.git/commit/bbb1b71

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.