Installing through UI (Update Manager), I get a series of errors that I don't get installing any other module.

* Notice: Undefined index: log in update_authorize_install_batch_finished() (line 236 of /modules/update/update.authorize.inc).
* Warning: Invalid argument supplied for foreach() in update_authorize_install_batch_finished() (line 236 of /modules/update/update.authorize.inc).
* Notice: Undefined index: log in update_authorize_install_batch_finished() (line 277 of /modules/update/update.authorize.inc).
* Notice: Undefined index: tasks in update_authorize_install_batch_finished() (line 278 of /modules/update/update.authorize.inc).

Comments

Blooniverse’s picture

... will try my best to have a look tomorrow.

Blooniverse’s picture

Priority: Critical » Normal

... please try out the most current 'Administrative pages 7.x-1.x-dev (2011-Feb-25)'. Don't forget to give feedback.

Blooniverse’s picture

Okay, the core module 'Update' seems to have a problem with the two arrays $results['log'] and $results['tasks']. Update's error message 'Undefined index' means that a particular value should be available -- but is not. I've come across dozens of these errors since the release of Drupal7 -- usually these occur due to an invalidly formulated or non existing check/validation (e.g. a lacking isset()) before the usage of an array element or variable.

Since my role as a co-maintainer of this module is very fresh/new, I'd like to ask @casey: Should 'Administrative Pages' define something, which is not defined yet? Or should we hand this issue over to the core module 'Update'?

update.authorize.inc

228:  /**
229:   * Batch callback for when the authorized install batch is finished.
230:   *
231:   * This processes the results and stashes them into SESSION such that
232:   * authorize.php will render a report. Also responsible for putting the site
233:   * back online after a successful install if necessary.
234:   */
235:  function update_authorize_install_batch_finished($success, $results) {
236:    foreach ($results['log'] as $project => $messages) {
237:      if (!empty($messages['#abort'])) {
238:        $success = FALSE;
239:      }
240:    }
274:  // Set all these values into the SESSION so authorize.php can display them.
275:  $_SESSION['authorize_results']['success'] = $success;
276:  $_SESSION['authorize_results']['page_message'] = $page_message;
277:  $_SESSION['authorize_results']['messages'] = $results['log'];
278:  $_SESSION['authorize_results']['tasks'] = $results['tasks'];
279:  $_SESSION['authorize_operation']['page_title'] = t('Update manager');
Blooniverse’s picture

Issue tags: +update

+Issue tag

casey’s picture

Status: Active » Fixed

I cannot reproduce. I guess this was a core issue, which is fixed in the mean time.

Though please re-open if you still encounter this error.

Status: Fixed » Closed (fixed)
Issue tags: -update

Automatically closed -- issue fixed for 2 weeks with no activity.