t() calls should be avoided in classes, use dependency injection and $this->t() instead.

CommentFileSizeAuthor
#5 3098955-5.patch544 bytesravi.shankar
#2 depedency_injection_use_this-3098955-2.patch549 bytesRangaswini

Comments

Rangaswini created an issue. See original summary.

Rangaswini’s picture

Rangaswini commented
StatusFileSize
new depedency_injection_use_this-3098955-2.patch549 bytes
Rangaswini’s picture

Rangaswini commented
Assigned: Rangaswini » Unassigned
Status: Active » Needs review
Lal_’s picture

Lal_
He\Him
commented
Status: Needs review » Needs work 
+++ b/src/AddToCalendarApiWidget.php
@@ -77,7 +77,7 @@ class AddToCalendarApiWidget {
+    $display_text = $this->t(':text', array(':text' => $this->atcDisplayText));

instead of array(), use [] instead

ravi.shankar’s picture

ravi.shankar commented
Status: Needs work » Needs review
StatusFileSize
new 3098955-5.patch544 bytes
shaktik’s picture

shaktik
he/him
Primary language Hindi
Location New Delhi
commented

Patch Looks good to me.

shaktik’s picture

shaktik
he/him
Primary language Hindi
Location New Delhi
commented
Status: Needs review » Reviewed & tested by the community