The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.Notice: Undefined index: HTTPS in /foo/bar/sites/all/modules/contrib/addthis/addthis.module on line 179
I highly recommend coding with PHP notices on. I find that I find more bugs faster.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | undefined_index_https-736816-9.patch | 3.1 KB | ultimike |
| #7 | PHP-notice-Undefined-index-HTTPS-736816-#7.diff | 2.99 KB | xtfer |
| #5 | addthis-https_warnings-6.x.patch | 2.82 KB | AlexisWilke |
| #3 | addthis-https_warnings-6.x.patch | 0 bytes | AlexisWilke |
| #2 | addthis_notices.patch | 1.74 KB | swentel |
Comments
Comment #1
Renee S commentedThis can be fixed by
if (!empty($_SERVER['HTTPS'])) {instead ofif ($_SERVER['HTTPS']) {:)
Comment #2
swentel commentedOr with an isset, it also happens on line 186
Comment #3
AlexisWilke commentedGuys there are 3 of those HTTPS tests... 8-)
Also, we are missing one in the MS-Windows special case.
There is a better patch.
Thank you.
Alexis Wilke
Comment #4
swentel commented@AlexisWilke patch is empty
Comment #5
AlexisWilke commentedWeird... trying again. Maybe I need to rename the file...
Okay, it looks like it worked!
Comment #6
dave reidDuplicate of #654180: php notices.
Comment #7
xtfer commentedEdit: Ignore this... rolled against the wrong release.
I couldn't get the patch from #5 to apply cleanly to 6.x-2.9, so I recreated it.
Comment #8
xtfer commentedClosing again. This issue is fixed in 6.x-3.x apparently.
Comment #9
ultimikeIn case anyone needs it, attached is a patch very similar to #7 above, but rolled against 6.x-2.10.
-mike