complaints that $_SERVER['HTTPS'] is undefined. Patch attached.

CommentFileSizeAuthor
#6 addthis_php_notices_new_version.diff3.6 KBvesapalmu
addthis_php_notices.diff2.03 KBdalin

Comments

dddave’s picture

dddave commented
Status: Active » Needs review

Correcting status.

robloach’s picture

robloach
he/him
commented
Status: Needs review » Reviewed & tested by the community

This is much cleaner.

marvil07’s picture

marvil07 commented

+1

thanks for the patch :-)

dddave’s picture

dddave commented

Is this committed?

marvil07’s picture

marvil07 commented

This patch is RTBC for more than 10 months ago and actually have two positive reviews. Is there any plans to include it? (please don't get me wrong, I appreciate the work here)

vesapalmu’s picture

vesapalmu commented
Status: Reviewed & tested by the community » Fixed
StatusFileSize
new addthis_php_notices_new_version.diff3.6 KB

I had to redo the patch since it had some minor security issues we used to had in previous module versions. The code has also changed a bit. The new version is now both commited to 2.x-dev branch and patch included to highlight the changes to the original patch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.