1. Create a new content type.
3. Go to the Activity Settings and remove the messages for the previously created content type for user role "All".
4. Create some content with the new type - insert, update, delete.
5. Logon to the server as anonymous user and go to the Activity page.
Observed behavior:
In the Activity page there is an empty table, not showing any content. There is a pager appearing on the bottom and you have to click on it until you find content, which is allowed to be shown.
Expected behavior:
The Activity page should show the first available content, which can be presented to the active user role.
--------
I have inspected the code and it looks like the devil is in the activity_token_replace method. This method knows how to handle properly the activities. However the other method activity_get_activity, which pulls the data doesn't care about the Activity settings and simply returns all the records up to the limit. We have to somehow combine these two methods.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | activity_query.patch | 1.55 KB | nekobul |
Comments
Comment #1
sirkitree commentedThank you for your detailed report. This has been a thorn in our side for quite some time and no one has come up with a solution as of yet.
Comment #2
nekobul commentedJerad,
I was able to setup an updated activity_get_activity method, which uses a new SQL statement to do the proper selection. It combines the information found in variable and activity table. Check the updated method for 5.x branch below. I don't have too much knowledge about the 6.x branch, but I don't think it is going to be too much of an hassle to include it there, too.
Comment #3
nekobul commentedJerad,
I haven't heard back from you what do you think about the solution I have proposed. Is there something you are concerned about?
Comment #4
sirkitree commentedSorry for the delay nekobul, I've been heavily involved in Activity2 for the 6.x branch lately and haven't paid a whole lot of attention to 5.x at all. Jaydub has been taking care of 5.x but I also know that he just started a new job recently and has had his hands full as well. I'm afraid 5.x is slowing going the way of the dinosaur.
That being said, if you could help us out by providing an actual patch file against 5.x-4.x-dev and maybe even (bonus points here) 6.x-1.x it's more likely to get a serious review. Also, to help catch our eyes a bit better, mark the issue as 'needs review' once you upload a patch file. Thanks!
Comment #5
jaydub commentedRegarding the 5.4 release, I do want to port all the work (that can be ported) from the 6.1 branch. I'm tied up for the next week with an international film festival at night and work during daytime but after that I hope to move quickly :)
Comment #6
nekobul commentedJeff,
Find attached patch file against activity-5.x-4.x-dev branch. The patch will be similar for 6.x branch if the created records in {variable} table haven't changed and {activity} and {activity_targets} table are the same.
Comment #7
nekobul commentedComment #8
nekobul commentedComment #9
sirkitree commented5.x unsupported please see 6.x-2
Comment #10
jrabeemer commented#6 patch seems to be working for me.