Problem/Motivation

Data flow is hard to follow, separate the widget in several parts:

listbox
combobox
autocomplete

so that data flow is clear and code is easier to manage.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork a11y_autocomplete-3244313

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nod_ created an issue. See original summary.

nod_ opened merge request !14

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented
Status: Active » Needs review
nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented

all up to date now

nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented
Status: Needs review » Reviewed & tested by the community

Looks good to me. Need more followups to clean up dataflow, docs, options passing, templating, etc.

  • nod_ committed 87df6f9 on 1.0.x 
    Issue #3244313 by nod_: Separate concerns
nod_’s picture

nod_
Primary language French
Location Lille
CreditAttribution: nod_ at Acquia commented
Status: Reviewed & tested by the community » Fixed
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
CreditAttribution: lauriii at Acquia commented

+1 for #5.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.