The latest commit from #2926651: Better UI needed for entering body text introduced 3 coding standards messages:

src/Entity/HelpTopic.php
line 375 Expected 1 space after SWITCH keyword; 0 found

src/Form/HelpTopicForm.php
12 Unused use statement

src/HelpTopicInterface.php
28 @throws comment must be on the next line

CommentFileSizeAuthor
#9 After-patch-apply-config-help.png188.55 KBSenthilMohith
#9 Before-patch-apply-config-help.png246.54 KBSenthilMohith
#7 config_help-coding_standards-2369943-7-D8.patch1.62 KBioana apetri
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhodgdon created an issue. See original summary.

SivaprasadC’s picture

SivaprasadC CreditAttribution: SivaprasadC as a volunteer and at DrupalPartners for Innoppl Technologies Pvt. Ltd commented
Assigned: Unassigned » SivaprasadC
ioana apetri’s picture

ioana apetri CreditAttribution: ioana apetri at OPTASY commented

Can I work on it? Or @Sivaprasad C is working on?
thanks

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

Thanks for your interest! Sivaprasad C claimed the issue (by assigning it to himself) about 13 hours ago, so let's give him time to finish it. If it isn't finished in a few days, then you could take it instead.

SivaprasadC’s picture

SivaprasadC CreditAttribution: SivaprasadC as a volunteer and at DrupalPartners for Innoppl Technologies Pvt. Ltd commented
Assigned: SivaprasadC » Unassigned

I tried to create a patch file, but I'm getting code sniffer error when doing with phpcs command.

ioana apetri’s picture

ioana apetri CreditAttribution: ioana apetri at OPTASY commented
Assigned: Unassigned » ioana apetri

I will create the patch then. Thanks for reply:)

ioana apetri’s picture

ioana apetri CreditAttribution: ioana apetri at OPTASY commented
Assigned: ioana apetri » Unassigned
Status: Active » Needs review
FileSize
config_help-coding_standards-2369943-7-D8.patch1.62 KB

Here is my patch. Please review it. Thanks.

SenthilMohith’s picture

SenthilMohith CreditAttribution: SenthilMohith as a volunteer and at DrupalPartners, Innoppl Technologies Pvt. Ltd commented
Assigned: Unassigned » SenthilMohith
SenthilMohith’s picture

SenthilMohith CreditAttribution: SenthilMohith as a volunteer and at DrupalPartners, Innoppl Technologies Pvt. Ltd commented
Assigned: SenthilMohith » Unassigned
Status: Needs review » Reviewed & tested by the community
FileSize
Before-patch-apply-config-help.png246.54 KB
After-patch-apply-config-help.png188.55 KB

I have tested this patch manually using the Coder Sniffer tool. It seems to be fixed and it's not throwing any coding standard error messages. Please find the attached screenshots.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

Thanks very much for the patch and the review! I will get this committed sometime soon (probably when I'm ready to commit another patch on this project).

  • jhodgdon committed 2683694 on 8.x-2.x 
    Issue #2931587 by yo30, SenthilMohith, jhodgdon: Fix 3 coding standards...
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Reviewed & tested by the community » Fixed

Thanks again! Committed and I'll update the Core patch shortly on #2920309: Add experimental module for Help Topics.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.