minor errors found in core/modules/migrate/tests/Drupal/migrate/Tests/MigrateSqlIdMapTest.php

 45 | ERROR | Missing short description in function doc comment
 46 | ERROR | There must be an empty line before the parameter block
 50 | ERROR | Missing comment for @return statement
 86 | ERROR | Array indentation error, expected 6 spaces but found 4
--------------------------------------------------------------------------------
CommentFileSizeAuthor
#5 imp-2139599-5.patch4.99 KBbdone
#2 comment-testSaveIdMapping-test.patch2.53 KBjessehs
#1 imp-codercs-2139599-1.patch1.89 KBbdone

Comments

bdone’s picture

bdone commented
Status: Active » Needs review
StatusFileSize
new imp-codercs-2139599-1.patch1.89 KB
jessehs’s picture

jessehs
he/him
Primary language English
Location Taos, New Mexico
commented
StatusFileSize
new comment-testSaveIdMapping-test.patch2.53 KB

Here's a different patch to provide documentation about each step of the test. This makes it easier to follow for n00bs like me :-)

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs review » Fixed

@bdone, looks like it's already committed.

@jessehs, your patch is separate from this issue, I would suggest opening a separate issue for improving in-line comments.

Thanks.

bdone’s picture

bdone commented
Status: Fixed » Needs work

still a few pending minor issues. i guess it's a good idea to clean these up as we go. might make the core patches easier?

<code>
FILE: ...core/modules/migrate/tests/Drupal/migrate/Tests/MigrateSqlIdMapTest.php
--------------------------------------------------------------------------------
FOUND 19 ERROR(S) AFFECTING 11 LINE(S)
--------------------------------------------------------------------------------
  66 | ERROR | Missing function doc comment
 123 | ERROR | Function comment short description must end with a full stop
 178 | ERROR | Function comment short description must be on a single line,
     |       | further text should be a separate paragraph
 181 | ERROR | Missing parameter type at position 1
 181 | ERROR | Missing comment for param "$num_source_fields" at position 1
 182 | ERROR | Missing parameter type at position 2
 182 | ERROR | Missing comment for param "$num_destination_fields" at position
     |       | 2
 232 | ERROR | Function comment short description must be on a single line,
     |       | further text should be a separate paragraph
 235 | ERROR | Missing parameter type at position 1
 235 | ERROR | Missing comment for param "$num_source_fields" at position 1
 236 | ERROR | Missing parameter type at position 2
 236 | ERROR | Missing comment for param "$num_destination_fields" at position
     |       | 2
 284 | ERROR | Function comment short description must be on a single line,
     |       | further text should be a separate paragraph
 287 | ERROR | Doc comment for var $num_source_fields does not match actual
     |       | variable name $num_error_rows at position 1
 287 | ERROR | Missing parameter type at position 1
 287 | ERROR | Missing comment for param "$num_source_fields" at position 1
 288 | ERROR | Superfluous doc comment at position 2
 288 | ERROR | Missing parameter type at position 2
 288 | ERROR | Missing comment for param "$num_destination_fields" at position
     |       | 2
--------------------------------------------------------------------------------

bdone’s picture

bdone commented
Status: Needs work » Needs review
StatusFileSize
new imp-2139599-5.patch4.99 KB

fixes are attached

bdone’s picture

bdone commented
Assigned: bdone » Unassigned
chx’s picture

chx commented
Status: Needs review » Fixed

Committed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.