Line number 355: public function getRowByDestination(array $destination_ids) {

CommentFileSizeAuthor
#4 2137479-4-test-getRowByDestination.patch1.96 KBjessehs
#2 2137479-2-phpunit-for-getRowByDestination.patch1.67 KBjessehs

Comments

jessehs’s picture

jessehs
he/him
Primary language English
Location Taos, New Mexico
commented
Assigned: Unassigned » jessehs
jessehs’s picture

jessehs
he/him
Primary language English
Location Taos, New Mexico
commented
Status: Active » Needs review
StatusFileSize
new 2137479-2-phpunit-for-getRowByDestination.patch1.67 KB

This checks whether the getRowByDestination method is successful. Does it also need to check if it fails when an invalid value is requested?

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs review » Needs work

As with getRowBySource(), I'd like to see a test with a non-existent destination ID.

jessehs’s picture

jessehs
he/him
Primary language English
Location Taos, New Mexico
commented
StatusFileSize
new 2137479-4-test-getRowByDestination.patch1.96 KB

This patch adds a check for a non-existent destination id, and asserts that it is false.

jessehs’s picture

jessehs
he/him
Primary language English
Location Taos, New Mexico
commented
Status: Needs work » Needs review
chx’s picture

chx commented

I will let Mike do this; but when you do, please quickfix + $this->assertSame(false, $result_row); to FALSE.

mikeryan’s picture

mikeryan
he/him
Primary language English
Location Pittsfield, MA, USA
commented
Status: Needs review » Fixed

Actually, I changed assertSame(false, ... to assertFalse.

Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.