Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.$action = isset($form['action']) ? $this->getAbsoluteUrl($form['action']) : $this->getUrl();
$action is set to a SimpleXML object if $form['action'] is defined which is then ignored by curl. The attribute needs to be cast to a string like everywhere else we access SimpleXML attributes.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | 947820-form-action.patch | 1.03 KB | boombatower |
Comments
Comment #1
boombatower CreditAttribution: boombatower commentedComment #2
boombatower CreditAttribution: boombatower commentedComment #3
webchickIf this is to block RC, you need to be explicit as to why.
Comment #4
boombatower CreditAttribution: boombatower commentedCompletely hidden, inexplicable results whenever a form action is used and the form is submitted through testing system. Still not a 100% sure where we draw the line, but this is a nasty bug that may pop up when contrib is testing... Feel free to mark either way, but I think it should get in regardless.
Comment #5
webchickIn terms of the "If we don't fix this before RC, will the project suffer irreparable harm" bar, I don't think this makes it. We have some 27K tests passing fine without this bug being fixed. So let's split the difference at major, I think.
Comment #6
bojanz CreditAttribution: bojanz commentedSaw this in the drupal_web_test_case.php that confirms boombatower's description:
The fix is trivial, nothing else needs to be said :)
Comment #7
webchickCommitted to HEAD. Thanks!
Comment #8
Damien Tournoud CreditAttribution: Damien Tournoud commentedEww. Was that really committed without any test?
Comment #9
webchickPwned!
Sorry. :(
Comment #10
catch