I found that locale tests are uses 'somehow works' approach to test export of strings.
Also there are some useless drupalLogout() at the end of a test

This patch could seriously help to continue work on #532512: Plural string storage is broken, editing UI is missing

CommentFileSizeAuthor
#22 interdiff_21-22.txt369 bytessourabhjain
#22 848966-22.patch4.11 KBsourabhjain
#21 interdiff_848966_20-21.txt1.02 KBankithashetty
#21 848966-21.patch4.13 KBankithashetty
#20 reroll_diff_19-20.txt2.4 KBimmaculatexavier
#20 848966-20.patch4.13 KBimmaculatexavier
#19 reroll_diff_17-19.txt1.98 KBimmaculatexavier
#19 848966-19.patch4.11 KBimmaculatexavier
#17 848966-17.patch4.06 KBimmaculatexavier
locale-tests-d7.patch4.5 KBandypost

Comments

andypost’s picture

andypost
he/him
Primary language Russian
commented

Export page have same forms so this fixes tests with change done in #601398: Simpletest does not allow assigning actions to triggers

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

subscribe

andypost’s picture

andypost
he/him
Primary language Russian
commented

locale-tests-d7.patch queued for re-testing.

thedavidmeister’s picture

thedavidmeister commented
Version: 7.x-dev » 8.0.x-dev
Issue summary: View changes
Status: Needs review » Needs work

I don't 100% understand the problem here, but looks like it might still be a problem in d8 as the code in the test is very similar, even if the comments have been updated to be less scary.

thedavidmeister’s picture

thedavidmeister commented
Assigned: andypost » Unassigned

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.6 was released on February 1, 2017 and is the final full bugfix release for the Drupal 8.2.x series. Drupal 8.2.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.3.0 on April 5, 2017. (Drupal 8.3.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.3.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
quietone’s picture

quietone commented
Version: 9.3.x-dev » 10.0.x-dev
Category: Bug report » Task
Issue tags: +Bug Smash Initiative, +Needs reroll

The patch is combing two Functional tests into one which makes sense in this case. However, this is a task.

The patch needs to be updated, adding tag.

immaculatexavier’s picture

immaculatexavier commented
StatusFileSize
new 848966-17.patch4.06 KB

Rerolled patch against 10.0.x

immaculatexavier’s picture

immaculatexavier commented
Status: Needs work » Needs review
immaculatexavier’s picture

immaculatexavier commented
StatusFileSize
new 848966-19.patch4.11 KB
new reroll_diff_17-19.txt1.98 KB

Rerolled patch against #17 with diff

immaculatexavier’s picture

immaculatexavier commented
StatusFileSize
new 848966-20.patch4.13 KB
new reroll_diff_19-20.txt2.4 KB

Rerolled patch against #19 with diff

ankithashetty’s picture

ankithashetty
Location Karnataka, India
commented
Issue tags: -Needs reroll
StatusFileSize
new 848966-21.patch4.13 KB
new interdiff_848966_20-21.txt1.02 KB

Fixed the custom command errors in #20, thanks!

sourabhjain’s picture

sourabhjain
Primary language English
commented
StatusFileSize
new 848966-22.patch4.11 KB
new interdiff_21-22.txt369 bytes

Fixed the custom command errors in #21, thanks!

Status: Needs review » Needs work

The last submitted patch, 22: 848966-22.patch, failed testing. View results

Version: 10.0.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.