node.language column should have an index

Patch attached for D8, and a reroll for D7.

Schema change only in D8, schema change and hook_update_n() in D7.

We also need an update hook to add the index for existing installs.

There are two patches in #3. One for D8 which is just the schema change, and one for D7 that has schema change and update hook.

No update hook is needed in D8 since HEAD->HEAD upgrades are currently not supported.

#3: 813634-add-node-language-index.patch queued for re-testing.

Rerolled new patch for D8 schema change.

The previous patch used the column name "language" instead of "langcode". Patch has been rerolled to include the correct column name.

maybe someone from d8mi can chime in here to rtbc it.

I dont see anything wrong, but I'm not knowledgable about performance and such.

tag didn't stick.

If at all possible, can we get an interdiff for this to make the review process a little easier?

• http://xjm.drupalgardens.com/blog/interdiffs-how-make-them-and-why-they-...
• http://drupal.org/node/1488712

Sorry for the delay, but I have now rerolled the patch and created an interdiff as requested.

This patch is so simple that the interdiff is actually larger than the patch :)

Needs reroll

Rerolling the patch #16

Investigated this and the patch is no longer needed because current D8 head already has:

'node_langcode' => array('langcode'),

So I believe this patch is no longer needed.

I agree, 'language' already has an index.. A bit more verbose:

In node.install you find:
$schema['node_field_revision'] = array(
'description' => 'Stores information about each saved version of a {node}.',
'fields' => array(
...
'indexes' => array(
'nid' => array('nid'),
'uid' => array('uid'),
'revision_uid' => array('revision_uid'),
'vid' => array('vid'),
'node_default_langcode' => array('default_langcode'),
'node_langcode' => array('langcode'),
),
...
'primary key' => array('nid', 'vid', 'langcode'),
);

Looks ok to me

Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/cc20016