Comma instead of period in flexible layout CSS [#745808]

Hi,

Panels uses a comma as decimal separator to format widths in percentages. For example.

.panels-flexible-region-12-center {
  float: left;
  width: 49,8513%;
}

This results in a broken layout in at least Firefox and Internet Explorer. Using number_format to explicitly format the widths in plugins/layouts/flexible/fliexilbe.inc with a period as decimal separator resolves this issue. I have attached a patch.

Comment	File	Size	Author
#3	panels-flexible-css-widths.patch	689 bytes	Robbert
#3
	panels.patch	689 bytes	Robbert

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Robbert CreditAttribution: Robbert commented 31 March 2010 at 16:45

Title:

Comma instead of period in flexible layout

» Comma instead of period in flexible layout CSS

Comment #2

sun

German

Karlsruhe

CreditAttribution: sun commented 31 March 2010 at 21:25

Status:

Needs review

» Needs work

Patch is reversed.

Comment #3

Robbert CreditAttribution: Robbert commented 1 April 2010 at 07:13

Status:

Needs work

» Needs review

File	Size
panels-flexible-css-widths.patch	689 bytes

Revised patch.

Comment #4

Robbert CreditAttribution: Robbert commented 11 May 2010 at 10:32

I think I have figured out why I am (judging on the activity of this bug) one of the few people for which this issue occurs. Consider the following code

echo 0.55.' ';
setlocale(LC_ALL, 'nl_NL');
echo 0.55;

This yields 0.55 0,55. So, clearly the fact that I'm using Dutch localization causes floats to be formated with commas as decimal separator. Hence, such percentages should clearly be formatted using number_format since CSS expects periods as decimal separators and we do not want one's localization settings breaking it.