#685074: (Tests needed) Some stream wrappers need to be hidden or read-only introduced a 'type' for stream wrappers which can be set in hook_stream_wrappers(), but the API documentation was not updated to reflect this change. Patch attached.

CommentFileSizeAuthor
#2 706718_stream_wrapper_api_update.patch1.16 KBgdd
stream_wrapper_api_update.patch1.16 KBgdd
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

One small thing: When you do a bullet list in API doc, you need to indent the following lines in an item two spaces

* regular text
* - beginning of a long
     list item
* - another list item
gdd’s picture

gdd
he/him
Primary language English
Location Portland, OR
CreditAttribution: gdd commented
FileSize
706718_stream_wrapper_api_update.patch1.16 KB

New patch

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

The format of the patch in #2 is fine.

And the grammar.

I don't know anything about stream wrappers, so can't review the content, but it looks reasonable.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Reviewed & tested by the community

Took a closer look and I think the content is fine too -- the example is following what's in system_stream_wrappers(). Let's get this in.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.