"feature missing" nag screen should be less nagging

I think this nagging should be moved somewhere else, now it's displayed too often. For example when saving the modules page.

Also, this nagging is displayed to non administrative users, which is totally wrong.

I would suggest, if you really want to display something, put a REQUIREMENTS_WARNING in hook_requirements so that it will show up on the status page.

Oh and in the current download, the parentheses on the t() are wrong which causes a general warning.

Attached patch moves the message to total_control_admin_settings(), which only user with permission 'administer total control' can access.

Perhaps could use markup instead of set message also.

I took the nag out of the dev version. I'm working on adding module-related features more gracefully in the 2.x branch.

Will add the nag back in here if this patch gets rewritten :)

I downloaded the dev version and I'm still getting the message

Ok, I now actually committed the nag-less version.

Sorry about that. :/

I still see this in 1.2, I ended up just enabling the statistics module so I wouldnt have to see it anymore

/**
 * Implementation of hook_views_default_views().
 */
function total_control_views_default_views() {
  $files = file_scan_directory(drupal_get_path('module', 'total_control'). '/views', '.view');
  foreach ($files as $filepath => $file) {
    require $filepath;
    
    // test for statistics module
    if (   ($file->name == 'control_activity' && !module_exists('statistics')) 
        || ($file->name == 'control_comments' && !module_exists('comment'))
        || ($file->name == 'control_terms' && !module_exists('taxonomy')) ){
      drupal_set_message(t('!feature features are being excluded because some needed modules are not enabled.', array('!feature' => substr($file->name,8))));
    }
    else {
      if (isset($view)) {
        $views[$view->name] = $view;
      }
    }
    
  }
  return $views;
}

I hate to sound completely clueless, but what do I need to do to fix this problem? As in, why is this message appearing?

@CLKeenen
You can either apply the patch in #6 above, or switch over to the dev version of the module.

This nag feature would be more useful if it had a link that takes you to a report that shows you what modules need to be enabled - or disabled - to remove the nag screen.

Alright, I've removed the nag and add a requirements check that just suggests other features might be hidden without these modules.

rerolled against latest dev. removed dpm. :)

this fix is committed to -dev and will be included in the next release.